password-hash: relax FromStr error bounds
#2120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the bound on `CustomizedPasswordHasher::Params` to remove the `Err = Error` bound on `FromStr`. Instead, the blanket impl of `PasswordVerifier` has been updated to require `Error: From<E>` where `E` is `FromStr::Err`. This allows crates to still use custom error types for params, which may be more expressive for a specific algorithm.
tarcieri
force-pushed
the
password-hash/relax-params-fromstr-error-bound
branch
from
72b67f9 to
d9e1f43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the bound on
CustomizedPasswordHasher::Paramsto remove theErr = Errorbound onFromStr.Instead, the blanket impl of
PasswordVerifierhas been updated to requireError: From<E>whereEisFromStr::Err.This allows crates to still use custom error types for params, which may be more expressive for a specific algorithm.