WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@ShaharNaveh
Copy link
Collaborator

@ShaharNaveh ShaharNaveh commented Nov 15, 2025

Summary by CodeRabbit

  • Chores
    • Updated Ruff-related dependencies to version 0.14.10, including updates to the Python parser, AST, text size, and source file modules.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 15, 2025

📝 Walkthrough

Walkthrough

This pull request updates Ruff-related dependencies in Cargo.toml from version 0.14.1 to 0.14.10. Four crates are bumped: ruff_python_parser, ruff_python_ast, ruff_text_size, and ruff_source_file. Their corresponding git revision hashes are updated to align with the new Ruff tag.

Changes

Cohort / File(s) Summary
Ruff dependency version bumps
Cargo.toml
Updated four Ruff-related dependencies (ruff_python_parser, ruff_python_ast, ruff_text_size, ruff_source_file) from tag 0.14.1 to 0.14.10 with corresponding git revision hash updates

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • youknowone

Poem

🐰 Ruff edges smoothed with a gentle hop,
From 0.14.1 to ten we did not stop,
Four crates aligned in perfect time,
Dependencies dance—a parser's rhyme!

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Update ruff to 0.14.10' directly and clearly summarizes the main change in the pull request: bumping the ruff dependency from version 0.14.1 to 0.14.10.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d3afd46 and 389d9d7.

⛔ Files ignored due to path filters (2)
  • Cargo.lock is excluded by !**/*.lock
  • Lib/test/test_syntax.py is excluded by !Lib/**
📒 Files selected for processing (1)
  • Cargo.toml
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-12-27T14:03:49.034Z
Learnt from: CR
Repo: RustPython/RustPython PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-27T14:03:49.034Z
Learning: Applies to **/*.py : Use ruff for linting Python code

Applied to files:

  • Cargo.toml
📚 Learning: 2025-12-27T14:03:49.034Z
Learnt from: CR
Repo: RustPython/RustPython PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-27T14:03:49.034Z
Learning: RustPython is a Python 3 interpreter written in Rust implementing Python 3.13.0+ compatibility with complete Python environment in Rust (not CPython bindings), clean implementation without compatibility hacks, and cross-platform support including WebAssembly compilation

Applied to files:

  • Cargo.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Run rust tests (windows-latest)
  • GitHub Check: Run snippets and cpython tests (windows-latest)
🔇 Additional comments (2)
Cargo.toml (2)

154-159: Commit hash verified against ruff tag 0.14.10.

The commit hash 45bbb4cbffe73cf925d4579c2e3eb413e0539390 correctly corresponds to ruff tag 0.14.10. All four ruff crate dependencies are pinned to the same commit hash, which ensures consistent versions and reproducible builds.


154-159: ruff 0.14.10 upgrade is safe—no breaking changes or security vulnerabilities in this version.

Verification shows:

  • No breaking changes in 0.14.10 (the breaking change for Python 3.14 default was introduced in 0.14.0)
  • No security advisories for 0.14.10; CVE-2025-62518 was fixed in 0.14.2, well before this version
  • The specific test failure reference (PR #21163) could not be verified in public sources, but the codebase appropriately manages failing tests through test markers as seen in recent commits

The commit hash approach for reproducible builds is sound.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@youknowone
Copy link
Member

test_syntax is broken

@ShaharNaveh
Copy link
Collaborator Author

Seems to be related to: astral-sh/ruff#21163 which is included in 0.14.4

@ShaharNaveh ShaharNaveh marked this pull request as draft November 26, 2025 10:51
@youknowone
Copy link
Member

lets mark it as expected failure and merge this. it doesn't hurt user experience.

@ShaharNaveh ShaharNaveh changed the title Update ruff to 0.14.5 Update ruff to 0.14.10 Dec 31, 2025
@ShaharNaveh ShaharNaveh marked this pull request as ready for review December 31, 2025 11:13
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youknowone youknowone merged commit 6ccf3b5 into RustPython:main Dec 31, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants