PMT Software Trigger class

[lynnt20]

Quick checklist

Goes with SBNSoftware/sbncode#604.

ClassVersion has been updated.

• Have you run git fetch and pulled the latest changes from the branch you're basing your PR against?
• If you're adding new classes, have you added them to classes_def.xml in the relevant directory?
• If you're updating classes, have you incremented the ClassVersion in classes_def.xml?

Description

Add SR class for software trigger objects.

[nathanielerowe]

@linyan-w @PetrilloAtWork similar to SBNSoftware/sbncode#604. I will consider this approved unless otherwise stated.

[linyan-w]

Looks good to me!

[kjplows]

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_12_02 SBNSoftware/sbncode#604

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[PetrilloAtWork]

There are show-stoppers with the checksums.

Also, comments need to be added to the data members.

[PetrilloAtWork]

Please regenerate this file.
Version 15 has its hash changed, which is not correct.

[PetrilloAtWork]

Place a comment explaining units and details. For example:

Suggested change

	int npmts = caf::kUninitializedInt;
	float flash_peaktime = caf::kSignalingNaN;
	float flash_peakpe = caf::kSignalingNaN;
	int npmts = caf::kUninitializedInt; ///< Number of PMT pairs above threshold at trigger time.
	float flash_peaktime = caf::kSignalingNaN; ///< Peak time of the reconstructed flash associated to the trigger [us]
	float flash_peakpe = caf::kSignalingNaN; ///< Peak amplitude of the reconstructed flash associated to the trigger, in photoelectron units.

I don't know if these descriptions are correct (that's why some should be there! 😄).
Exception: the time unit can be omitted if it is the standard CAF one (microseconds). However, given that sometimes trigger-related times are specified in nanoseconds, it's still worth to be explicit.

[PetrilloAtWork]

Add ClassVersion="10" and rebuild, so that ROOT generates a checksum.

Suggested change

	<class name="caf::SRSoftwareTrigger" />
	<class name="caf::SRSoftwareTrigger" ClassVersion="10" />

[kjplows]

Thanks for catching this @PetrilloAtWork , and apologies for the overly zealous merge 😅

[kjplows]

@lynnt20 -- please take note of these comments. I will reopen a PR identical to this one. Thanks and sorry for the confusion!