-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[rb] improve selenium manager testing #16767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
Thank you, @titusfortner for this code suggestion. The support packages contain example code that many users find helpful, but they do not necessarily represent After reviewing the change, unless it is a critical fix or a feature that is needed for Selenium We actively encourage people to add the wrapper and helper code that makes sense for them to their own frameworks. |
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||||||||||||
4a36f9d to
22affab
Compare
…ain permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
User description
🔗 Related Issues
Ruby version of #16741
💥 What does this PR do?
🔧 Implementation Notes
💡 Additional Considerations
I might want to go back and use this approach in #16741 now
PR Type
Tests, Enhancement
Description
Refactors Selenium Manager tests to run independently with medium size
Adds manager tag to service specs and updates test assertions
Implements guard condition for SE_FORCE_BROWSER_DOWNLOAD environment variable
Adds CI workflow job to run manager tests on all OS platforms
Updates type signatures for optional parameters in RBS files
Diagram Walkthrough
File Walkthrough
7 files
Dynamic test size based on manager tagAdd dedicated Selenium Manager test job for all OSSeparate service spec with manager tagSeparate service spec with manager tagSeparate service spec with manager tagCreate new BUILD file with manager service testSeparate service spec with manager tag5 files
Refactor to test Selenium Manager functionalityRefactor to test Selenium Manager functionalityRefactor to test Selenium Manager functionalityRefactor to test Selenium Manager functionalityRefactor to test Selenium Manager functionality1 files
Add manager guard condition for environment variable2 files
Make initialize parameter optional in type signatureMake block parameter optional in add_condition signature