-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[py] pin python versions to specific patches #16795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||
cgoldberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is fine if it helps with cache, but I like the idea of just using the latest patch release for each version. With this, we will constantly have to bump the versions as new releases come out if we want to use them.
|
Kind of the point that it shouldn't change versions without you knowing. Ideally dependabot or whatever would know to look at python rules in module. 😂 |
|
Also it's nice that this PR shows where we aren't referencing python with bazel properly |
User description
I noted that there are a bunch of slightly different python toolchain caches generated that may come from different patch versions, so this ensures everything is pinned to the same thing.
💥 What does this PR do?
PR Type
Enhancement
Description
Upgrade rules_python from 1.6.3 to 1.7.0
Pin Python toolchain versions to specific patch releases
Ensure consistent Python environment across all build configurations
Add missing py_binary import to scripts BUILD file
Diagram Walkthrough
File Walkthrough
MODULE.bazel
Upgrade rules_python and pin Python patch versionsMODULE.bazel
3.11.14, 3.12.12, 3.13.9, 3.14.0)
versions
BUILD.bazel
Add py_binary import to scripts BUILD filescripts/BUILD.bazel