api: re-enable OrderingFilter and expose ordering_fields=['id'] for stable pagination #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks Jakob for raising the issue, the solution is to add a consistent order_by('id') to the get_queryset calls, and the issue is now solved on the production API as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Page-number pagination on several API list endpoints can return duplicate and missing rows because ordering is not deterministic (OrderingFilter was disabled and the queryset doesn’t enforce an order).
/api/sc/polity-territories/?page_size=100: API count = 606; fetched rows = 606; unique ids = 587 (19 duplicates). Duplicate ids vary across runs.
Change
Re-enable DRF filters.OrderingFilter and expose ordering_fields=['id']. This allows clients to request ?ordering=id, yielding deterministic, indexed ordering.