WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Fixed the deletion of ConVar/ConCommand not managed by Source.Python. #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CookStar wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed the deletion of ConVar/ConCommand not managed by Source.Python. #426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/core/sp_main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,9 +409,6 @@ void CSourcePython::Unload( void )
DevMsg(1, MSG_PREFIX "Clearing all commands...\n");
ClearAllCommands();

DevMsg(1, MSG_PREFIX "Unregistering ConVar...\n");
ConVar_Unregister( );

Copy link
Contributor

@jordanbriere jordanbriere Dec 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace with:

	// See issue #430.
	// DevMsg(1, MSG_PREFIX "Unregistering ConVar...\n");
	// ConVar_Unregister( );

// New in CSGO...
#if defined(ENGINE_CSGO) || defined(ENGINE_BLADE)
DevMsg(1, MSG_PREFIX "Disconnecting interfaces...\n");
Expand Down