-
Notifications
You must be signed in to change notification settings - Fork 444
Improve build tooling: fix CGL issues and enhance Makefile #6239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
linawolf
merged 3 commits into
TYPO3-Documentation:main
from
CybotTM:feature/improve-build-tooling
Nov 26, 2025
Merged
Improve build tooling: fix CGL issues and enhance Makefile #6239
linawolf
merged 3 commits into
TYPO3-Documentation:main
from
CybotTM:feature/improve-build-tooling
Nov 26, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace deprecated @PER-CS1.0 ruleset with @PER-CS1x0 as recommended by php-cs-fixer. The old ruleset triggers deprecation warnings during CGL checks.
Add explicit PHP >=8.2 requirement to satisfy php-cs-fixer's composer.json validation which expects a PHP version constraint.
Major improvements to the build tooling: Structure: - Extract repeated values into variables (DOCKER_IMAGE, DOCS_DIR, etc.) - Organize targets into logical sections with headers - Add .DEFAULT_GOAL := help for better discoverability - Rename composerUpdate to composer-update for consistency Bug fixes: - Fix test-cgl running same command as fix-cgl (now uses -n dry-run flag) - Correct copy-pasted and inaccurate target descriptions New features: - Add check-dependencies guard with clear error message - Add clean target for removing generated files - Add docs-open target for quick preview in browser All dependent targets now provide helpful error messages when dependencies are not installed instead of cryptic failures.
linawolf
approved these changes
Nov 26, 2025
Member
linawolf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, this looks great!
Contributor
|
The backport to stderrstdoutTo backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-13.4 13.4
# Navigate to the new working tree
cd .worktrees/backport-13.4
# Create a new branch
git switch --create backport-6239-to-13.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick e32140c40e1d4370b500a716ea35806111e85d0c,48fd1f478b89796c8d58ba90aa88f51153d05a25,1d81e2bf934460c10b0ed2907c6fa0118f21b448
# Push it to GitHub
git push --set-upstream origin backport-6239-to-13.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-13.4Then, create a pull request where the |
froemken
pushed a commit
that referenced
this pull request
Dec 9, 2025
* fix(build): use non-deprecated PER-CS ruleset in php-cs-fixer Replace deprecated @PER-CS1.0 ruleset with @PER-CS1x0 as recommended by php-cs-fixer. The old ruleset triggers deprecation warnings during CGL checks. * fix(build): add PHP version requirement to composer.json Add explicit PHP >=8.2 requirement to satisfy php-cs-fixer's composer.json validation which expects a PHP version constraint. * refactor(build): improve Makefile structure and developer experience Major improvements to the build tooling: Structure: - Extract repeated values into variables (DOCKER_IMAGE, DOCS_DIR, etc.) - Organize targets into logical sections with headers - Add .DEFAULT_GOAL := help for better discoverability - Rename composerUpdate to composer-update for consistency Bug fixes: - Fix test-cgl running same command as fix-cgl (now uses -n dry-run flag) - Correct copy-pasted and inaccurate target descriptions New features: - Add check-dependencies guard with clear error message - Add clean target for removing generated files - Add docs-open target for quick preview in browser All dependent targets now provide helpful error messages when dependencies are not installed instead of cryptic failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
php-cs-fixer fixes
@PER-CS1.0ruleset with@PER-CS1x0Makefile improvements
Structure:
.DEFAULT_GOAL := helpfor better discoverabilitycomposerUpdatetocomposer-updatefor kebab-case consistencyBug fixes:
test-cglrunning same command asfix-cgl(now uses-ndry-run flag)New features:
check-dependenciesguard with clear error message when dependencies missingcleantarget for removing generated filesdocs-opentarget for quick preview in browserTest plan
make helpto verify target descriptions are accuratemake test-cglto verify dry-run mode (should report issues without modifying files)make fix-cglto verify it still fixes issuesmake docsto verify documentation renderingmake cleanto verify cleanup worksmake installfirst to verify helpful error message