-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
ci: sync config between projects #6130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| { | ||
| "$schema": "https://unpkg.com/@changesets/[email protected].1/schema.json", | ||
| "$schema": "https://unpkg.com/@changesets/[email protected].2/schema.json", | ||
| "changelog": [ | ||
| "@svitejs/changesets-changelog-github-compact", | ||
| { "repo": "TanStack/table" } | ||
|
|
@@ -10,5 +10,8 @@ | |
| "updateInternalDependencies": "patch", | ||
| "fixed": [], | ||
| "linked": [], | ||
| "ignore": [] | ||
| "ignore": [], | ||
| "___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH": { | ||
| "onlyUpdatePeerDependentsWhenOutOfRange": true | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| # Auto detect text files and perform LF normalization | ||
| * text=auto | ||
| * text=auto eol=lf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -53,3 +53,15 @@ jobs: | |
| run: pnpm run build:all | ||
| - name: Publish Previews | ||
| run: pnpx pkg-pr-new publish --pnpm --compact './packages/*' --template './examples/*/*' | ||
| provenance: | ||
| name: Provenance | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/[email protected] | ||
| with: | ||
| fetch-depth: 0 | ||
| - name: Check Provenance | ||
| uses: danielroe/[email protected] | ||
| with: | ||
| fail-on-downgrade: true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1 @@ | ||
| link-workspace-packages=true | ||
| prefer-workspace-packages=true | ||
| provenance=true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,36 +1,37 @@ | ||
| { | ||
| "name": "table", | ||
| "namespace": "@tanstack", | ||
| "private": true, | ||
| "repository": "https://github.com/tanstack/table.git", | ||
| "packageManager": "[email protected]", | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/tanstack/table.git" | ||
| }, | ||
| "packageManager": "[email protected]", | ||
| "type": "module", | ||
| "scripts": { | ||
| "clean": "pnpm --filter \"./packages/**\" run clean", | ||
| "preinstall": "node -e \"if(process.env.CI == 'true') {console.log('Skipping preinstall...'); process.exit(1)}\" || npx -y only-allow pnpm", | ||
| "test": "pnpm run test:ci", | ||
| "test:pr": "nx affected --targets=test:format,test:sherif,test:knip,test:lib,test:types,build", | ||
| "test:ci": "nx run-many --targets=test:format,test:sherif,test:knip,test:lib,test:types,build", | ||
| "test:pr": "nx affected --targets=test:sherif,test:knip,test:docs,test:lib,test:types,build", | ||
| "test:ci": "nx run-many --targets=test:sherif,test:knip,test:docs,test:lib,test:types,build", | ||
| "test:format": "pnpm run prettier --check", | ||
| "test:sherif": "sherif -i react -i react-dom -i vue -i solid-js -i svelte -i @builder.io/qwik", | ||
| "test:lib": "nx affected --targets=test:lib --exclude=examples/**", | ||
| "test:lib:dev": "pnpm test:lib && nx watch --all -- pnpm test:lib", | ||
| "test:types": "nx affected --targets=test:types --exclude=examples/**", | ||
| "test:knip": "knip", | ||
| "test:docs": "node scripts/verify-links.ts", | ||
| "build": "nx affected --targets=build --exclude=examples/** && size-limit", | ||
| "build:all": "nx run-many --targets=build --exclude=examples/** && size-limit", | ||
| "watch": "pnpm run build:all && nx watch --all -- pnpm run build:all", | ||
| "dev": "pnpm run watch", | ||
| "prettier": "prettier --ignore-unknown '**/*'", | ||
| "prettier": "prettier --experimental-cli --ignore-unknown '**/*'", | ||
| "prettier:write": "pnpm run prettier --write", | ||
| "verify-links": "node scripts/verify-links.ts", | ||
| "changeset": "changeset", | ||
| "changeset:version": "changeset version && pnpm install --no-frozen-lockfile && pnpm prettier:write", | ||
| "changeset:publish": "changeset publish" | ||
| }, | ||
| "nx": { | ||
| "includedScripts": [ | ||
| "test:format", | ||
| "test:docs", | ||
| "test:knip", | ||
| "test:sherif" | ||
| ] | ||
|
|
@@ -59,7 +60,6 @@ | |
| "@rollup/plugin-terser": "^0.4.4", | ||
| "@size-limit/preset-small-lib": "^11.1.4", | ||
| "@svitejs/changesets-changelog-github-compact": "^1.2.0", | ||
| "@tanstack/config": "^0.13.0", | ||
| "@testing-library/jest-dom": "^6.4.6", | ||
| "@testing-library/react": "^16.0.0", | ||
| "@testing-library/react-hooks": "^8.0.1", | ||
|
|
@@ -75,7 +75,7 @@ | |
| "rollup-plugin-size": "^0.3.1", | ||
| "rollup-plugin-svelte": "^7.2.2", | ||
| "rollup-plugin-visualizer": "^5.12.0", | ||
| "sherif": "^0.9.0", | ||
| "sherif": "^1.6.1", | ||
| "size-limit": "^11.1.4", | ||
| "tinyglobby": "^0.2.15", | ||
| "typescript": "5.4.5", | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π§© Analysis chain
π Web query:
prettier 3.3.2 --experimental-cli flag documentationπ‘ Result:
Short answer: The --experimental-cli flag is not part of Prettier 3.3.2 β it was introduced later as an experimental high-performance CLI behind a feature flag (usable as --experimental-cli or via PRETTIER_EXPERIMENTAL_CLI=1) and documented in Prettier release/blog and CLI docs. See Prettier blog announcing the experimental CLI and the CLI docs for usage. [1][2][3]
Sources
π Script executed:
cat package.json | head -30Repository: TanStack/table
Length of output: 1560
π Script executed:
Repository: TanStack/table
Length of output: 1248
The
--experimental-cliflag is not available in prettier 3.3.2 and will cause an error.According to prettier documentation, the
--experimental-cliflag was introduced after version 3.3.2 (announced June 23, 2025). Since the package.json specifies"prettier": "^3.3.2", using this flag will fail if prettier 3.3.2 is installed. Either remove the flag or update the prettier version constraint to a version that supports it (3.4.0 or later, if available, or remove the caret to allow installation of newer versions).