[js-api][web-api] Use the 'react' algorithm from WebIDL #1835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for drafting this so quickly! I think the comment from 1834 also applies to https://webassembly.github.io/spec/js-api/#instantiate-a-promise-of-a-module |
Ms2ger
changed the title
Member
|
@Ms2ger, is this old PR still relevant? If so, who could review it? |
Ms2ger
force-pushed
the
web-promise-react
branch
from
d8ef842 to
ca839f2
Compare
Ms2ger
force-pushed
the
web-promise-react
branch
from
ca839f2 to
1f7dbcd
Compare
Collaborator
Author
|
@rossberg Ryan approved, but doesn't have write access. Could you merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1834.