-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add setting to hide shared glossary components in projects they are s… #15708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (71.42%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #15708 +/- ##
=======================================
Coverage 91.51% 91.51%
=======================================
Files 667 667
Lines 69634 69640 +6
Branches 7117 7118 +1
=======================================
+ Hits 63726 63732 +6
+ Misses 4135 4134 -1
- Partials 1773 1774 +1
🚀 New features to boost your workflow:
|
|
This pull request has been automatically marked as stale because there wasn’t any recent activity. It will be closed soon if no further action occurs. Thank you for your contributions! |
|
Not stale |
36fc460 to
73e77dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new setting HIDE_SHARED_GLOSSARY_COMPONENTS to hide shared glossary components from project component lists, helping reduce translator confusion by hiding components that aren't meant to be translated directly.
Key changes:
- Introduces filtering logic to exclude shared glossary components when the setting is enabled
- Adds configuration options for both Docker and regular deployments
- Provides documentation for the new setting
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| weblate/trans/views/basic.py | Implements filtering logic to hide shared glossary components in project views |
| weblate/settings_example.py | Adds the new setting with default value of False |
| weblate/settings_docker.py | Adds Docker environment variable support for the setting |
| docs/admin/install/docker.rst | Documents the Docker environment variable |
| docs/admin/config.rst | Documents the new setting with description and usage |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
The new option should be documented in https://docs.weblate.org/en/latest/admin/projects.html#share-in-projects so that it is clear that glossary components might not be visible with it turned on. PS: Please address the Copilot reviews, these are definitely valid points. |
|
This pull request has been automatically marked as stale because there wasn’t any recent activity. It will be closed soon if no further action occurs. Thank you for your contributions! |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
c1bd1a9 to
c0ea71d
Compare
|
This pull request has been automatically marked as stale because there wasn’t any recent activity. It will be closed soon if no further action occurs. Thank you for your contributions! |

Glossary components are typically shared into other projects to make them available for translation translation work.
When these are visible in the compnoent list of projects which are using them, it can cause confusion or distract translators from
the actual components that are meant to be translated.
This PR adds a setting which hides those shared glossary components.