WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@softworkz
Copy link
Contributor

Glossary components are typically shared into other projects to make them available for translation translation work.
When these are visible in the compnoent list of projects which are using them, it can cause confusion or distract translators from
the actual components that are meant to be translated.

This PR adds a setting which hides those shared glossary components.

@codecov
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.51%. Comparing base (cd39f3b) to head (c0ea71d).
⚠️ Report is 590 commits behind head on main.

Files with missing lines Patch % Lines
weblate/trans/views/basic.py 71.42% 1 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (71.42%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #15708   +/-   ##
=======================================
  Coverage   91.51%   91.51%           
=======================================
  Files         667      667           
  Lines       69634    69640    +6     
  Branches     7117     7118    +1     
=======================================
+ Hits        63726    63732    +6     
+ Misses       4135     4134    -1     
- Partials     1773     1774    +1     
Files with missing lines Coverage Δ
weblate/trans/views/basic.py 87.12% <71.42%> (-0.42%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Sep 4, 2025

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

@github-actions github-actions bot added the wontfix Will be closed when no feedback arrives. label Sep 4, 2025
@softworkz
Copy link
Contributor Author

Not stale

Copilot AI review requested due to automatic review settings September 4, 2025 12:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new setting HIDE_SHARED_GLOSSARY_COMPONENTS to hide shared glossary components from project component lists, helping reduce translator confusion by hiding components that aren't meant to be translated directly.

Key changes:

  • Introduces filtering logic to exclude shared glossary components when the setting is enabled
  • Adds configuration options for both Docker and regular deployments
  • Provides documentation for the new setting

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
weblate/trans/views/basic.py Implements filtering logic to hide shared glossary components in project views
weblate/settings_example.py Adds the new setting with default value of False
weblate/settings_docker.py Adds Docker environment variable support for the setting
docs/admin/install/docker.rst Documents the Docker environment variable
docs/admin/config.rst Documents the new setting with description and usage

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot removed the wontfix Will be closed when no feedback arrives. label Sep 5, 2025
@nijel
Copy link
Member

nijel commented Sep 5, 2025

The new option should be documented in https://docs.weblate.org/en/latest/admin/projects.html#share-in-projects so that it is clear that glossary components might not be visible with it turned on.

PS: Please address the Copilot reviews, these are definitely valid points.

@nijel nijel added this to the 5.14 milestone Sep 5, 2025
@nijel nijel removed this from the 5.14 milestone Oct 3, 2025
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

@github-actions github-actions bot added the wontfix Will be closed when no feedback arrives. label Nov 3, 2025
@softworkz
Copy link
Contributor Author

I've commited the AI suggestions.

Also enabled edits:

image

@github-actions github-actions bot removed the wontfix Will be closed when no feedback arrives. label Nov 4, 2025
@github-actions
Copy link

github-actions bot commented Dec 4, 2025

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

@github-actions github-actions bot added wontfix Will be closed when no feedback arrives. and removed wontfix Will be closed when no feedback arrives. labels Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants