-
Notifications
You must be signed in to change notification settings - Fork 28
Add GitHub Action to automate ai.zip release asset #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Add GitHub Action to automate ai.zip release asset #115
Conversation
- Triggers on release publish - Reuses existing build-plugin-zip workflow - Downloads built artifact - Uploads ai.zip as release asset Fixes WordPress#109
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @alishanvr. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #115 +/- ##
==========================================
Coverage 29.61% 29.61%
Complexity 145 145
==========================================
Files 14 14
Lines 878 878
==========================================
Hits 260 260
Misses 618 618
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dkotter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left this comment on another PR/Issue but I don't think we need a separate GitHub Action for this as the Action we have that deploys to WP.org will already attach the final asset to the release (see https://github.com/WordPress/ai/blob/develop/.github/workflows/wporg-plugin-deploy.yml#L54)
We can leave this PR open for now until we've verified our current approach works
|
Got it, thanks! I'll wait for your verification. Let me know if you need anything from me. 👍 |
What?
Adds automated GitHub Action workflow to build and attach
ai.zipto releases.Closes #109
This PR creates a new workflow that automatically generates the plugin zip file and attaches it as a release asset whenever a new release is published on GitHub.
Why?
Currently, the plugin zip must be manually packaged and attached to each GitHub release. This creates extra work and potential for inconsistency across releases.
Issue #109 requested automation to:
ai.zip)How?
The implementation:
.github/workflows/release.ymlthat triggers onrelease: publishedeventsbuild-plugin-zip.yamlworkflow (DRY principle)ai.zipas a release asset usingsoftprops/action-gh-releaseThe workflow follows WordPress security best practices:
Testing Instructions
Local Build Verification
ai.zipis created successfullyWorkflow Testing (Maintainers Only)
build-plugin-zip.yamlworkflow which requiresSVN_USERNAMEsecret that only exists in the WordPress/ai repository.To test in the WordPress/ai repository:
trunkv0.2.0-rc1)v0.2.0-rc1, Target:trunkai.zipappears in the Assets sectionExpected Results
ai.zipappears in release assetsTesting Instructions for Keyboard
N/A - This PR does not affect the user interface. It only adds backend automation for release management.
Screenshots or screencast
N/A - This is a CI/CD workflow change with no visual output. The workflow will appear in the Actions tab when releases are published.
Test Evidence (Local Build)
Additional Notes
Why Reusing
build-plugin-zip.yaml?Security Considerations