797: Default range question type to start at 0 #803
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #797
Why is this the best possible solution? Were any other approaches considered?
Changed the default start to 0 instead of 1 based on the XLSForm specification: https://xlsform.org/en/#range
What are the regression risks?
Users / libraries expecting the default to be 1.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No change required for XLSForm docs, it appears ODK Docs doesn't specify range question defaults for
start,end, andstep.Before submitting this PR, please make sure you have:
testspython -m unittestand verified all tests passruff format pyxform testsandruff check pyxform teststo lint code