WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@Zachary-Sutherby
Copy link

Closes #797

Why is this the best possible solution? Were any other approaches considered?

Changed the default start to 0 instead of 1 based on the XLSForm specification: https://xlsform.org/en/#range

What are the regression risks?

Users / libraries expecting the default to be 1.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No change required for XLSForm docs, it appears ODK Docs doesn't specify range question defaults for start, end, and step.

Before submitting this PR, please make sure you have:

  • included test cases for core behavior and edge cases in tests
  • run python -m unittest and verified all tests pass
  • run ruff format pyxform tests and ruff check pyxform tests to lint code
  • verified that any code or assets from external sources are properly credited in comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Range question type default should start at 0 and not 1

1 participant