WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Moved the scs conf from --conf to env var #4177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
timma-yelp wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Moved the scs conf from --conf to env var #4177

timma-yelp wants to merge 1 commit into from

Conversation

@timma-yelp
Copy link
Contributor

@timma-yelp timma-yelp commented Dec 5, 2025 •
edited
Loading

  1. Moved the scs conf from --conf to env var
  2. Adjusted the test cases accordingly
  3. Added the other required AWS properties to env var
  4. Upgraded service_configuration_lib to 3.3.7
  5. paasta validate ran successfully (logs)

@timma-yelp timma-yelp requested a review from a team as a code owner December 5, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nemacysts nemacysts Awaiting requested review from nemacysts

@austinzh austinzh Awaiting requested review from austinzh

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@timma-yelp