Quote every non color string #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederikbosch
force-pushed
the
master
branch
from
7c856d7 to
32161a6
Compare
gkatsev
added a commit
to gkatsev/rootbeer
that referenced
this pull request
Jun 9, 2021
Taking a play from acdlite/json-sass#14, this change makes it so that string values that contain colors do not get quotes. Specifically, this includes hex colors, rgb, rgba, hsl, hsla, and css color names. Fixes #4 BREAKING CHANGE: colors will no longer be quotes with this release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR quotes every string that is not a color (starts with #). Maybe I should extend that with more possible language constructs. @acdlite Could you tell me if you like the PR and the likelihood of merging?