WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@SteffenDE
Copy link
Contributor

Similar to #277 / #311.

I did not regenerate the schema files for now.

@SteffenDE SteffenDE requested a review from a team as a code owner December 9, 2025 16:36
@benbrandt
Copy link
Member

@SteffenDE for some reason I can't push to your PRs.... I'm guessing the checkbox for "allow maintainers to edit" isn't checked?

Copy link
Member

@benbrandt benbrandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't have done it better myself! There is one small tweak I want to make to make mcp servers optional (wish we had in the other requests) and generate the schema, but I can't seem to push....

@benbrandt
Copy link
Member

Solved it by doing it from your repo

@benbrandt benbrandt enabled auto-merge (squash) December 11, 2025 14:03
@benbrandt benbrandt merged commit 54ead78 into agentclientprotocol:main Dec 11, 2025
1 check passed
@acp-release-bot acp-release-bot bot mentioned this pull request Dec 11, 2025
@SteffenDE
Copy link
Contributor Author

@benbrandt it's weird because I don't have that checkbox on this PR, but I remember seeing it in the past in different repositories...

@SteffenDE SteffenDE deleted the sd-session-resume2 branch December 11, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants