feat: Add QR code output with completion URL #186
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmyers
reviewed
Dec 3, 2025
src/anaconda_auth/actions.py
Outdated
| import qrcode | ||
|
|
||
| # Create a QR code object | ||
| qr = qrcode.QRCode( |
Contributor
There was a problem hiding this comment.
maybe this should be in the except below, like the browser didn't open
Collaborator
Author
There was a problem hiding this comment.
Agree. I don't think we want to do both. I could also see using that as the default, but being able to opt-in to QR code via config.
Collaborator
Author
There was a problem hiding this comment.
Check out the new logic I implemented. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
POC / Work-in-Progress.
Allows outputting QR code in terminal during device flow for completion via phone.