Add Flipper feature flag to TransferFromStripeToWiseJob #1506
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Flipper feature flag to TransferFromStripeToWiseJob
Summary
Added a Flipper feature flag (
:transfer_from_stripe_to_wise) to gate the execution ofTransferFromStripeToWiseJob. When the flag is disabled, the job returns early without processing any consolidated payments. Created comprehensive specs testing both enabled and disabled states.Changes:
Flipper.enabled?(:transfer_from_stripe_to_wise)check at the start of theperformmethodbackend/spec/sidekiq/transfer_from_stripe_to_wise_job_spec.rbwith 5 test cases covering:Review & Testing Checklist for Human
sidekiq_schedule.yml. Verify that having it run but do nothing when disabled is acceptable vs. disabling the schedule itself.Test Plan
Flipper.enabled?(:transfer_from_stripe_to_wise)Flipper.enable(:transfer_from_stripe_to_wise)Flipper.disable(:transfer_from_stripe_to_wise)Notes
share_certificatesflag inShareHolding)Link to Devin run: https://app.devin.ai/sessions/23264d6928a44b78b3189a510f065c6f
Requested by: Ershad Kunnakkadan ([email protected])