feat: resend all button for missed posts/emails #2246

sm17p · 2025-12-08T08:12:30Z

Closes #1814

Send all missed posts button #1814
Link to Figma
Previos PR feat: resend all button for missed posts/emails #2149

This PR enables a user to resend all missed posts/emails using a single button. Missed posts can be further filtered by a workflow using the Select box.

The section title is changed from Send Missed Posts to a Select box which allows a user to filter missed posts by workflow
When Resend All is clicked, a sidekiq job is triggered to send all of the missed emails
Business logic used for sending posts single/bulk is re-factored into SendPostsForPurchaseService service, which is then used throughout the code base.
Users who have opted out of receiving comms are not sent any emails for single/bulk resend paths
There is an additional empty state which wasn't a part of the design presented inside the demo video. It's displayed when no missed posts are present (had to do this so users could switch properly between selected workflows)

Changes After #2149

Using partial visit to CustomersController#index to fetch drawer data (customer emails, missed posts and workflows) in a single API call instead of /customers/missed_posts/:purchase_id and /customers/customer_emails/:purchase_id endpoints, which are now removed from codebase.
We're now checking user's opt-out status for receiving emails inside SendPostsForPurchaseService#send_post
Polling behviour is added to check for delivery status of missed posts after "Resend All" action

Before

before_send_missed_posts_individually.mov

After

Screenshots

Device	Light	Dark
Desktop
Mobile

Demo

1. Send all missed posts with polling for delivery status

polling-works.mov

Mails delivered

2. Inertial partial visits to fetch customer emails, missed posts and workflows

inertia-partial-loader.mov

3. Polling cancels when

User selects a new workflow
User selects a new purchase record
User closes the drawer
polling-cancels-on-switching-worfklow_or_purchase_or_closing_drawer.mov

Specs Passing

bundle exec rspec spec/policies/installment_policy_spec.rb spec/services/send_posts_for_purchase_service_spec.rb spec/requests/customers/customers_spec.rb:457 spec/sidekiq/send_missed_posts_job_spec.rb spec/controllers/posts_controller_spec.rb spec/policies/audience/purchase_policy_spec.rb spec/controllers/workflows_controller_spec.rb spec/presenters/workflow_presenter_spec.rb spec/presenters/workflows_presenter_spec.rb spec/models/installment/installment_class_methods_spec.rb

AI Disclosure

For #2149

Cursor Ask Mode (Auto Model) for understanding code base
Cursor Plan Mode + Build (Sonnet 4.5 + Composer) for initial draft
Cursor Agent Mode (Auto) for co-ordinated edits + debugging

For #2246

Cursor auto mode for edits and debugging

Live Stream Disclosure

Have watched all four live streams

sm17p

@EmCousin _a I've updated the PR description showcasing partial visit and polling behaviour.

Also, left a few review comments to explain my changes, feel free to ping in-case it's not understandable

There's just one actionable comment from previous review #2149 (comment) which might need your attention

Please have a look where you're free 🙏

sm17p · 2025-12-08T08:23:23Z

app/controllers/customers_controller.rb

+    if !request.inertia_partial?
+      product = Link.fetch(params[:link_id]) if params[:link_id].present?
+      sales = fetch_sales(products: [product].compact)
+      customers_presenter = CustomersPresenter.new(
+        pundit_user:,
+        product:,
+        customers: load_sales(sales),
+        pagination: { page: 1, pages: (sales.results.total / CUSTOMERS_PER_PAGE.to_f).ceil, next: nil },
+        count: sales.results.total
+      )
+      create_user_event("customers_view")
+    end
+
+    purchase = current_seller.sales.find_by_external_id!(params[:purchase_id]) if params[:purchase_id].present?

-    render inertia: "Customers/Index",
-           props: { customers_presenter: customers_presenter.customers_props }
+    render inertia: "Customers/Index", props: {
+      customers_presenter: (-> { customers_presenter.customers_props } if !request.inertia_partial?),
+      customer_emails: InertiaRails.optional { fetch_customer_emails(purchase) },
+      missed_posts: InertiaRails.optional { CustomerPresenter.new(purchase:).missed_posts(workflow_id: params[:workflow_id]) },
+      workflows: InertiaRails.optional { WorkflowsPresenter.new(seller: current_seller).workflow_options_by_purchase_props(purchase:) },
+    }.compact


Fetches drawer data on partial visits

sm17p · 2025-12-08T08:24:59Z

app/controllers/customers_controller.rb

    render json: []
  end

-  def customer_emails


Moved to #index to reduce network calls as per #2149 (comment)

sm17p · 2025-12-08T08:25:27Z

app/controllers/customers_controller.rb

+      customers_presenter: (-> { customers_presenter.customers_props } if !request.inertia_partial?),
+      customer_emails: InertiaRails.optional { fetch_customer_emails(purchase) },
+      missed_posts: InertiaRails.optional { CustomerPresenter.new(purchase:).missed_posts(workflow_id: params[:workflow_id]) },
+      workflows: InertiaRails.optional { WorkflowsPresenter.new(seller: current_seller).workflow_options_by_purchase_props(purchase:) },


Moved over here as per #2149 (comment)

sm17p · 2025-12-08T08:26:39Z

app/javascript/components/Admin/Users/UserList.tsx

-import EmptyState from "$app/components/Admin/EmptyState";
 import PaginatedLoader, { type Pagination } from "$app/components/Admin/PaginatedLoader";
 import UserCard, { type User } from "$app/components/Admin/Users/User";
+import EmptyState from "$app/components/ui/EmptyState";


Re-factored as per #2149 (comment)

sm17p · 2025-12-08T08:34:40Z

app/javascript/components/Audience/CustomersPage.tsx

      customers: prev.customers.map((customer) => (customer.id === id ? { ...customer, ...update } : customer)),
    }));
  const [isLoading, setIsLoading] = React.useState(false);
+  const [isLoadingPurchaseData, setIsLoadingPurchaseData] = React.useState(false);


This helps in displaying a loader for "Missed Posts" and "Emails" section when the drawer is open and a new purchase record is selected

sm17p · 2025-12-08T14:04:56Z

spec/services/send_posts_for_purchase_service_spec.rb

+      expect(PostSendgridApi.mails.keys).to include(purchase.email)
+    end
+
+    it "raises CustomerOptedOutError when purchase has opted out" do


Newly added case which checks for opt out status

sm17p · 2025-12-08T14:05:13Z

spec/sidekiq/send_missed_posts_job_spec.rb

+      end.to raise_error(ActiveRecord::RecordNotFound)
+    end
+
+    it "handles CustomerOptedOutError gracefully without retrying" do


Newly added case which checks for opt out status

sm17p · 2025-12-08T14:06:37Z

app/javascript/components/Audience/CustomersPage.tsx

+    setLoadingId("all");
+    try {
+      const response = await resendPosts(customer.id, selectedWorkflowId === "" ? undefined : selectedWorkflowId);
+      trackPostsBeingSent(customer.id, selectedWorkflowId === "" ? undefined : selectedWorkflowId);


Poll for email delivery status

sm17p · 2025-12-08T14:07:47Z

app/javascript/components/Audience/CustomersPage.tsx

+          purchase_id: purchaseId,
+          workflow_id: workflowId,
+        },
+        only: ["customer_emails", "missed_posts"],


This transfers the mails from sending -> sent bucket

sm17p · 2025-12-08T14:08:35Z

app/javascript/components/Audience/CustomersPage.tsx

+    }
+  };
+
+  React.useEffect(() => () => stopPolling(), [customer.id, selectedWorkflowId]);


Poll cancellation conditions

User selects a new workflow

User selects a new purchase record

User closes the drawer

If the user closes the drawer immediately after queuing the resend, the job might finish but we never refresh the “missed posts” state because the interval was cleaned up, correct? If so, when they reopen the drawer later, they’ll still see the stale list until they manually reload.

Overall this polling mechanism is a bit complicated for what we need here. It would be simpler and much more deterministic to send a completion status from the server via WebSocket since we already use Anycable: you could send a completion status when the job is complete and you could subscribe here to cleanup the posts and show an success toaster.

sm17p · 2025-12-09T08:51:45Z

app/javascript/components/Audience/CustomersPage.tsx

+          }
+        },
+      });
+    }, 3500);


Polling via usePoll hook from inertiajs doesn't work with dynamic requestOptions because the hook captures requestOptions in a closure on first render via useRef.

When selectedWorkflowId changes, the poll continues using the initial value, therefore we need to write custom polling logic

https://github.com/inertiajs/inertia/blob/3516b03f98fbccd04b77521c3312f044bd254439/packages/react/src/usePoll.ts#L4-L17

// Inertia bug explanation const { start: trackPostsBeingSent, stop: stopTrackingPostsBeingSent } = usePoll( 3500, // requestOptions { data: { purchase_id: customer.id, // This value changes when switching between workflows, // but poll calls don't reflect the change and continue using // the initial value of `undefined`. workflow_id: selectedWorkflowId === "" ? undefined : selectedWorkflowId, }, only: ["customer_emails", "missed_posts"], preserveUrl: true, onSuccess: (page) => { const { missed_posts } = cast<{ missed_posts?: MissedPost[] }>(page.props); if (!missed_posts?.length) { stopTrackingPostsBeingSent(); setLoadingId(null); showAlert("All missed emails were sent", "success"); } }, }, { autoStart: false, }, );

EmCousin

This approach is far superior to the previous one - added some comments to cover the edge cases. Should be good to merge then!

app/controllers/customers_controller.rb

EmCousin · 2025-12-08T16:21:42Z

app/controllers/posts_controller.rb

+      if @post.seller_id?
+        @seller = @post.seller
+      else
+        @seller = @post.link.seller


Can you explain why you need to set @seller here?

This is for reasons highlighted over #2149 (comment) and #2149 (comment)

EmCousin · 2025-12-08T16:23:37Z

app/javascript/components/Audience/CustomersPage.tsx

+      onSuccess: () => setIsLoadingPurchaseData(false),
+      onError: () => setIsLoadingPurchaseData(false),


Suggested change

onSuccess: () => setIsLoadingPurchaseData(false),

onError: () => setIsLoadingPurchaseData(false),

onFinish: () => setIsLoadingPurchaseData(false),

Ideally Inertia should provide a loading attribute so we don't have to reinvent this

Let me have look what can be made out of it

app/javascript/components/Audience/CustomersPage.tsx

app/services/send_posts_for_purchase_service.rb

app/sidekiq/send_missed_posts_job.rb

EmCousin · 2025-12-09T13:24:56Z

app/controllers/posts_controller.rb

+
+    SendPostsForPurchaseService.send_missed_posts_for(purchase: @purchase, workflow_id: params[:workflow_id])
+
+    render json: { message: "Missed emails are queued for delivery" }, status: :ok


If the purchase opted out, we could return a 422 status with an error toast straight away instead of enqueue-ing the job. This is more coherent from the user's standpoint. We would still need to check that at the job level (in the event of retries for instance).

This should already be handled as there is a before_action :ensure_can_contact_for_purchase, only: %i[send_for_purchase send_missed_posts] callback in the controller which does it.

I'll handle it differently though using validation at service level and change the error code as well

EmCousin · 2025-12-09T13:40:49Z

app/javascript/components/Audience/CustomersPage.tsx

+    }
+  };
+
+  React.useEffect(() => () => stopPolling(), [customer.id, selectedWorkflowId]);


If the user closes the drawer immediately after queuing the resend, the job might finish but we never refresh the “missed posts” state because the interval was cleaned up, correct? If so, when they reopen the drawer later, they’ll still see the stale list until they manually reload.

Overall this polling mechanism is a bit complicated for what we need here. It would be simpler and much more deterministic to send a completion status from the server via WebSocket since we already use Anycable: you could send a completion status when the job is complete and you could subscribe here to cleanup the posts and show an success toaster.

sm17p and others added 14 commits November 26, 2025 23:04

send all missed posts at once

c6e1694

send all missed posts by workflows

c5d25a6

Merge branch 'main' into missed-posts

84b00eb

cleanup

6d7d549

cleanup 2

b610cd1

cleanup 3

daa443e

cleanup 4

f112065

Merge branch 'main' into missed-posts

2794e93

Merge branch 'main' into missed-posts

4693bbf

Merge branch 'main' into missed-posts

ce377ba

use inertia partial reload for fetching drawer data

1ddb52c

cleanup 1

b949696

do not include post from other variant

85ddd36

poll for sent posts

c2ba1ab

sm17p commented Dec 8, 2025

View reviewed changes

neetogit-bot bot assigned EmCousin Dec 8, 2025

Merge branch 'main' into missed-posts

dd09124

sm17p marked this pull request as ready for review December 8, 2025 14:13

Merge branch 'main' into missed-posts

e180b1d

sm17p commented Dec 9, 2025

View reviewed changes

EmCousin requested changes Dec 9, 2025

View reviewed changes

EmCousin closed this Dec 9, 2025

		onSuccess: () => setIsLoadingPurchaseData(false),
		onError: () => setIsLoadingPurchaseData(false),

	onSuccess: () => setIsLoadingPurchaseData(false),
	onError: () => setIsLoadingPurchaseData(false),
	onFinish: () => setIsLoadingPurchaseData(false),


		SendPostsForPurchaseService.send_missed_posts_for(purchase: @purchase, workflow_id: params[:workflow_id])

		render json: { message: "Missed emails are queued for delivery" }, status: :ok

feat: resend all button for missed posts/emails #2246

feat: resend all button for missed posts/emails #2246

Uh oh!

Conversation

sm17p commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Closes #1814

Changes After #2149

Before

After

Screenshots

Demo

1. Send all missed posts with polling for delivery status

2. Inertial partial visits to fetch customer emails, missed posts and workflows

3. Polling cancels when

Specs Passing

AI Disclosure

For #2149

For #2246

Live Stream Disclosure

Uh oh!

sm17p left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sm17p Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EmCousin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

sm17p commented Dec 8, 2025 •

edited

Loading

sm17p left a comment •

edited

Loading

sm17p Dec 8, 2025 •

edited

Loading