GH-48355: [Python] Remove obsolete snprintf workaround for Python 3.9 #48354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
For reviewers I am trying to get used to the dev, reading documentation and code bit by bit so I happened to create a lot of minor PRs 🙏 . |
Member
|
These kind of contributions are very welcome! |
Member
|
Thanks for the contributions! echoing @AlenkaF see our definition for MINOR here: |
Member
Author
|
Thanks, will do |
HyukjinKwon
changed the title
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
e9b9042 added the workaround for Python 3.9 on Windows. However, PyArrow dropped Python 3.9 at aedb752. Per python/cpython@e822e37, this should be fine to be removed.
What changes are included in this PR?
This PR proposes to remove obsolete snprintf workaround for Python 3.9 on Windows.
Are these changes tested?
I tested locally but do not have Windows environment. I will rely on CI.
Are there any user-facing changes?
No.