chore: Add microbenchmarks for all expressions #2984
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2984 +/- ##
============================================
+ Coverage 56.12% 59.58% +3.46%
- Complexity 976 1377 +401
============================================
Files 119 167 +48
Lines 11743 15493 +3750
Branches 2251 2569 +318
============================================
+ Hits 6591 9232 +2641
- Misses 4012 4962 +950
- Partials 1140 1299 +159 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andygrove
changed the title
Member
Author
|
I am going to split this up into smaller PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2955
I will mark as ready for review after #2964, #2979, and #2980 are merged.
Rationale for this change
Add remaining benchmarks to cover all expressions. I can split these out into smaller PRs after the holidays if needed ... or we could just merge as is and then follow up with smaller PRs for any improvements that anyone wants. This PR gives us instant coverage of all expressions, which is helpful in prioritizing optimization efforts.
What changes are included in this PR?
How are these changes tested?