WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

perf: Improve string expression microbenchmarks #3012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andygrove merged 6 commits into from
Jan 6, 2026
+26 −21
Merged

perf: Improve string expression microbenchmarks #3012

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b471c32
improve string benchmarks
andygrove Dec 29, 2025
1403394
Merge remote-tracking branch 'apache/main' into improve-string-benchm…
andygrove Jan 2, 2026
9af4184
skip some CI workflows for benchmark changes
andygrove Jan 2, 2026
6869f79
skip failing suite
andygrove Jan 2, 2026
5e46911
Merge branch 'skip-ci-bench' into improve-string-benchmarks
andygrove Jan 2, 2026
e3442ab
upmerge
andygrove Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 26 additions & 21 deletions spark/src/test/scala/org/apache/spark/sql/benchmark/CometStringExpressionBenchmark.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,43 +35,48 @@ case class StringExprConfig(
query: String,
extraCometConfigs: Map[String, String] = Map.empty)

// spotless:off
/**
* Benchmark to measure performance of Comet string expressions. To run this benchmark:
* `SPARK_GENERATE_BENCHMARK_FILES=1 make benchmark-org.apache.spark.sql.benchmark.CometStringExpressionBenchmark`
* {{{
* SPARK_GENERATE_BENCHMARK_FILES=1 make benchmark-org.apache.spark.sql.benchmark.CometStringExpressionBenchmark
* }}}
* Results will be written to "spark/benchmarks/CometStringExpressionBenchmark-**results.txt".
*/
// spotless:on
object CometStringExpressionBenchmark extends CometBenchmarkBase {

// Configuration for all string expression benchmarks
private val stringExpressions = List(
StringExprConfig("Substring", "select substring(c1, 1, 100) from parquetV1Table"),
StringExprConfig("ascii", "select ascii(c1) from parquetV1Table"),
StringExprConfig("bitLength", "select bit_length(c1) from parquetV1Table"),
StringExprConfig("octet_length", "select octet_length(c1) from parquetV1Table"),
StringExprConfig("upper", "select upper(c1) from parquetV1Table"),
StringExprConfig("lower", "select lower(c1) from parquetV1Table"),
StringExprConfig("chr", "select chr(c1) from parquetV1Table"),
StringExprConfig("initCap", "select initCap(c1) from parquetV1Table"),
StringExprConfig("trim", "select trim(c1) from parquetV1Table"),
StringExprConfig("bit_length", "select bit_length(c1) from parquetV1Table"),
StringExprConfig("btrim", "select btrim(c1) from parquetV1Table"),
StringExprConfig("ltrim", "select ltrim(c1) from parquetV1Table"),
StringExprConfig("rtrim", "select rtrim(c1) from parquetV1Table"),
StringExprConfig("lpad", "select lpad(c1, 120, 'x') from parquetV1Table"),
StringExprConfig("rpad", "select rpad(c1, 120, 'x') from parquetV1Table"),
StringExprConfig("chr", "select chr(c1) from parquetV1Table"),
StringExprConfig("concat", "select concat(c1, c1) from parquetV1Table"),
StringExprConfig("concatws", "select concat_ws(' ', c1, c1) from parquetV1Table"),
Copy link
Contributor

@mbutrovich mbutrovich Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems like a good catch.

StringExprConfig("concat_ws", "select concat_ws(' ', c1, c1) from parquetV1Table"),
StringExprConfig("contains", "select contains(c1, '123') from parquetV1Table"),
StringExprConfig("startsWith", "select startswith(c1, '123') from parquetV1Table"),
StringExprConfig("endsWith", "select endswith(c1, '123') from parquetV1Table"),
StringExprConfig("endswith", "select endswith(c1, '9') from parquetV1Table"),
StringExprConfig("initCap", "select initCap(c1) from parquetV1Table"),
StringExprConfig("instr", "select instr(c1, '123') from parquetV1Table"),
StringExprConfig("length", "select length(c1) from parquetV1Table"),
StringExprConfig("like", "select c1 like '%123%' from parquetV1Table"),
StringExprConfig("lower", "select lower(c1) from parquetV1Table"),
StringExprConfig("lpad", "select lpad(c1, 150, 'x') from parquetV1Table"),
StringExprConfig("ltrim", "select ltrim(c1) from parquetV1Table"),
StringExprConfig("octet_length", "select octet_length(c1) from parquetV1Table"),
StringExprConfig(
"regexp_replace",
"select regexp_replace(c1, '[0-9]', 'X') from parquetV1Table"),
StringExprConfig("repeat", "select repeat(c1, 3) from parquetV1Table"),
StringExprConfig("reverse", "select reverse(c1) from parquetV1Table"),
StringExprConfig("instr", "select instr(c1, '123') from parquetV1Table"),
StringExprConfig("replace", "select replace(c1, '123', 'ab') from parquetV1Table"),
StringExprConfig("reverse", "select reverse(c1) from parquetV1Table"),
StringExprConfig("rlike", "select c1 rlike '[0-9]+' from parquetV1Table"),
StringExprConfig("rpad", "select rpad(c1, 150, 'x') from parquetV1Table"),
StringExprConfig("rtrim", "select rtrim(c1) from parquetV1Table"),
StringExprConfig("space", "select space(2) from parquetV1Table"),
StringExprConfig("translate", "select translate(c1, '123456', 'aBcDeF') from parquetV1Table"))
StringExprConfig("startswith", "select startswith(c1, '1') from parquetV1Table"),
StringExprConfig("substring", "select substring(c1, 1, 100) from parquetV1Table"),
StringExprConfig("translate", "select translate(c1, '123456', 'aBcDeF') from parquetV1Table"),
StringExprConfig("trim", "select trim(c1) from parquetV1Table"),
StringExprConfig("upper", "select upper(c1) from parquetV1Table"))

override def runCometBenchmark(mainArgs: Array[String]): Unit = {
runBenchmarkWithTable("String expressions", 1024) { v =>
Expand Down