feat: add AstMemoryEstimator for SQL AST memory estimation #16882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackieTien97
requested changes
Dec 11, 2025
Contributor
JackieTien97
left a comment
JackieTien97
left a comment
There was a problem hiding this comment.
IMO, making Node implements Accountable interface may be the best way.
| } | ||
|
|
||
| private void addNodeSize(Node node) { | ||
| totalMemorySize += RamUsageEstimator.shallowSizeOfInstance(node.getClass()); |
Contributor
There was a problem hiding this comment.
Node's InstanceSize should be a constant, no need to calculate each time.
| import java.util.Optional; | ||
|
|
||
| /** Utility class for estimating memory usage of AST nodes. */ | ||
| public final class AstMemoryEstimator { |
Contributor
There was a problem hiding this comment.
It's hard to maintain this class, if any Node has some changes or new Node being added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.