fix tests in BatchedAlignedSeriesReadChunkCompactionTest #16885
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix flaky tests in
BatchedAlignedSeriesReadChunkCompactionTestDescription
This PR fixes 12 flaky tests in
BatchedAlignedSeriesReadChunkCompactionTestthat were failing intermittently due to non-deterministic iteration order of collections.Root Cause
The
getPaths()method inAbstractCompactionTest.javahad two sources of non-determinism:HashSetusage: The method usedHashSet<IFullPath>which does not guarantee iteration orderschemaMap.values(): ThemeasurementSchemaslist was created directly fromschemaMap.values()without sorting, and sinceschemaMapis backed by aConcurrentHashMap, the iteration order is non-deterministicThis caused
AlignedFullPathobjects to be created with measurements in different orders across test runs, leading to comparison failures when validating compaction results.Fix
HashSettoLinkedHashSetto preserve insertion ordermeasurementSchemasby measurement name before creating the listChanges
File:
iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/AbstractCompactionTest.javaTests Fixed
BatchedAlignedSeriesReadChunkCompactionTest#testCompactionWithDifferentCompressionTypeOrEncodingBatchedAlignedSeriesReadChunkCompactionTest#testCompactionWithEmptyBatchBatchedAlignedSeriesReadChunkCompactionTest#testSimpleCompactionByFlushChunkBatchedAlignedSeriesReadChunkCompactionTest#testSimpleCompactionByFlushPageBatchedAlignedSeriesReadChunkCompactionTest#testSimpleCompactionByWritePointBatchedAlignedSeriesReadChunkCompactionTest#testSimpleCompactionWithAllDeletedColumnByFlushChunkBatchedAlignedSeriesReadChunkCompactionTest#testSimpleCompactionWithAllDeletedPageByFlushPageBatchedAlignedSeriesReadChunkCompactionTest#testSimpleCompactionWithNotExistColumnByFlushChunkBatchedAlignedSeriesReadChunkCompactionTest#testSimpleCompactionWithNullColumnBatchedAlignedSeriesReadChunkCompactionTest#testSimpleCompactionWithNullColumnByFlushChunkBatchedAlignedSeriesReadChunkCompactionTest#testSimpleCompactionWithPartialDeletedColumnByFlushChunkBatchedAlignedSeriesReadChunkCompactionTest#testSimpleCompactionWithPartialDeletedPageByWritePointVerification
Verified using NonDex with 3 different random seeds - all tests pass consistently.