WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@leon-inf
Copy link
Contributor

No description provided.

@leon-inf leon-inf added this to the Release 1.1.0 milestone Nov 12, 2025
@leon-inf leon-inf requested a review from kizuna-lek November 12, 2025 09:02
@apecloud-bot
Copy link
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.0

@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines. label Nov 12, 2025
@leon-inf
Copy link
Contributor Author

/nopick

@apecloud-bot apecloud-bot added the nopick Not auto cherry-pick when PR merged label Nov 12, 2025
@leon-inf leon-inf force-pushed the support/paramaters-volume-watcher branch 3 times, most recently from 924be07 to c516959 Compare November 13, 2025 02:14
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 66.30435% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.86%. Comparing base (42f835b) to head (b85984c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/parameters/configmanager/config_handler.go 69.49% 14 Missing and 4 partials ⚠️
pkg/parameters/configmanager/reload_util.go 44.44% 10 Missing ⚠️
pkg/parameters/configmanager/handler_util.go 77.77% 1 Missing and 1 partial ⚠️
pkg/parameters/config_util.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9856      +/-   ##
==========================================
- Coverage   50.95%   50.86%   -0.10%     
==========================================
  Files         546      542       -4     
  Lines       59183    58767     -416     
==========================================
- Hits        30159    29889     -270     
+ Misses      26050    25937     -113     
+ Partials     2974     2941      -33     
Flag Coverage Δ
unittests 50.86% <66.30%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leon-inf leon-inf marked this pull request as ready for review November 13, 2025 02:27
@leon-inf leon-inf requested a review from a team as a code owner November 13, 2025 02:27
@leon-inf leon-inf changed the title chore: remove the volume watcher from config-manager chore: remove the volume watcher and signal hander from config-manager Nov 13, 2025
@leon-inf leon-inf force-pushed the support/paramaters-volume-watcher branch from c516959 to 7c108ba Compare November 13, 2025 05:44
@apecloud-bot apecloud-bot added the approved PR Approved Test label Nov 13, 2025
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Nov 14, 2025
@apecloud-bot apecloud-bot added the approved PR Approved Test label Nov 14, 2025
@leon-inf leon-inf merged commit 379684d into main Nov 14, 2025
40 checks passed
@leon-inf leon-inf deleted the support/paramaters-volume-watcher branch November 14, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR Approved Test nopick Not auto cherry-pick when PR merged size/XXL Denotes a PR that changes 1000+ lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants