fix: update alt text for log icon and correct dropdown dependency (#4… #41439

pratapaprasanna · 2025-12-02T11:40:51Z

…1432)

Changed the alt text for the log icon from "icon" to "Plugin icon" for better accessibility.
Fixed a dependency issue in the useDropdown hook by replacing handleOnDropdownOpen with handleOnDropdownClose in the dependency array.

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

Summary by CodeRabbit

Bug Fixes
- Fixed dropdown component to properly track state dependencies, improving handler behavior stability.
- Improved accessibility of error log icons in the debugger with updated descriptive text.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

…1432) - Changed the alt text for the log icon from "icon" to "Plugin icon" for better accessibility. - Fixed a dependency issue in the useDropdown hook by replacing handleOnDropdownOpen with handleOnDropdownClose in the dependency array.

coderabbitai · 2025-12-02T11:41:21Z

Walkthrough

Two minor bug fixes: an accessibility alt text update for an error log icon renderer, and a dependency array correction in a dropdown hook to include the proper close handler reference instead of a duplicate.

Changes

Cohort / File(s)	Summary
Error Log Icon Rendering `app/client/src/ce/components/editorComponents/Debugger/ErrorLogs/getLogIconForEntity.tsx`	Alt attribute updated from "icon" to "Plugin icon" for ACTION entity case
Dropdown Hook Dependencies `app/client/src/widgets/useDropdown.tsx`	Fixed useCallback dependency array: removed duplicate `handleOnDropdownOpen`, added `handleOnDropdownClose` for proper memoization

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐛 Small fixes, big impact they say,
Alt text reads clear as the light of day,
Dependencies now aligned just right,
Two tiny tweaks—but oh, what a sight! 🎯

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description covers the changes made but lacks critical details like issue reference, motivation, and context as required by the template.	Add issue reference (Fixes #XXXX), explain motivation/context for both changes, and confirm DevRel/Marketing notification requirement.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main changes: accessibility improvement via alt text update and a dependency fix in the dropdown hook.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/accessibility-and-hooks

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 780c3c8 and 51de084.

📒 Files selected for processing (2)

app/client/src/ce/components/editorComponents/Debugger/ErrorLogs/getLogIconForEntity.tsx (1 hunks)
app/client/src/widgets/useDropdown.tsx (1 hunks)

🧰 Additional context used

🧠 Learnings (6)

📚 Learning: 2024-12-11T08:25:39.197Z

Learnt from: brayn003
Repo: appsmithorg/appsmith PR: 38088
File: app/client/src/git/components/GitContextProvider/hooks/useGitBranches.ts:40-43
Timestamp: 2024-12-11T08:25:39.197Z
Learning: In `app/client/src/git/components/GitContextProvider/hooks/useGitBranches.ts`, the `useMemo` hook includes dependencies `artifactType` and `baseArtifactId` in its dependency array.

Applied to files:

app/client/src/widgets/useDropdown.tsx

📚 Learning: 2024-12-11T08:33:24.352Z

Learnt from: brayn003
Repo: appsmithorg/appsmith PR: 38088
File: app/client/src/git/components/GitQuickActions/BranchButton/index.tsx:72-74
Timestamp: 2024-12-11T08:33:24.352Z
Learning: In the 'BranchButton' component in 'app/client/src/git/components/GitQuickActions/BranchButton/index.tsx' (TypeScript, React), the `useEffect` hook that checks for label ellipsis does not need to include `currentBranch` in its dependency array.

Applied to files:

app/client/src/widgets/useDropdown.tsx

📚 Learning: 2025-02-20T13:36:10.743Z

Learnt from: alex-golovanov
Repo: appsmithorg/appsmith PR: 39379
File: app/client/src/pages/AppIDE/components/LibrariesList/JSLibrariesSection.tsx:0-0
Timestamp: 2025-02-20T13:36:10.743Z
Learning: When reviewing React components, ensure that useMemo and useEffect hooks include all variables used within their callbacks in their dependency arrays to prevent stale values and potential bugs.

Applied to files:

app/client/src/widgets/useDropdown.tsx

📚 Learning: 2024-11-12T11:42:28.998Z

Learnt from: ankitakinger
Repo: appsmithorg/appsmith PR: 37330
File: app/client/src/pages/common/SearchBar/HomepageHeaderAction.tsx:95-95
Timestamp: 2024-11-12T11:42:28.998Z
Learning: In icon provider components within the TypeScript/React codebase, old settings icons like `"settings-2-line"` and `"settings-control"` are intentionally provided alongside new icons. These references are acceptable and should not be flagged for updates.

Applied to files:

app/client/src/ce/components/editorComponents/Debugger/ErrorLogs/getLogIconForEntity.tsx

📚 Learning: 2024-07-26T21:12:57.228Z

Learnt from: ankitakinger
Repo: appsmithorg/appsmith PR: 29573
File: app/client/src/pages/Editor/Explorer/Entity/EntityProperties.tsx:46-65
Timestamp: 2024-07-26T21:12:57.228Z
Learning: The use of `any` for the `entityProperties` parameter in the `getJSActionBindings` function within `EntityProperties.tsx` is intentional and should not be suggested for refactoring to improve type safety.

Applied to files:

app/client/src/ce/components/editorComponents/Debugger/ErrorLogs/getLogIconForEntity.tsx

📚 Learning: 2024-10-08T15:32:34.114Z

Learnt from: ankitakinger
Repo: appsmithorg/appsmith PR: 29573
File: app/client/src/pages/Editor/Explorer/Entity/EntityProperties.tsx:240-0
Timestamp: 2024-10-08T15:32:34.114Z
Learning: The `ENTITY_TYPE.MODULE_INSTANCE` case in `EntityProperties.tsx` is intentionally a combination of the logic from both `ENTITY_TYPE.ACTION` and `ENTITY_TYPE.JSACTION`, which explains the presence of what might seem like duplicated code.

Applied to files:

app/client/src/ce/components/editorComponents/Debugger/ErrorLogs/getLogIconForEntity.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
GitHub Check: client-unit-tests / client-unit-tests
GitHub Check: client-prettier / prettier-check
GitHub Check: client-lint / client-lint
GitHub Check: client-build / client-build

🔇 Additional comments (2)

app/client/src/ce/components/editorComponents/Debugger/ErrorLogs/getLogIconForEntity.tsx (1)

50-50: Accessibility improvement approved.

The updated alt text "Plugin icon" is more descriptive than the generic "icon" for screen readers.

app/client/src/widgets/useDropdown.tsx (1)

94-94: Dependency array bug fixed.

Correctly replaced the duplicate handleOnDropdownOpen with handleOnDropdownClose, which is used on line 85. This prevents stale closures when the dropdown state changes.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

pratapaprasanna · 2025-12-02T11:45:13Z

/build-deploy-preview skip-tests=true

github-actions · 2025-12-02T11:45:34Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/19857479708.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 41439.
recreate: .

github-actions · 2025-12-02T11:56:25Z

Deploy-Preview-URL: https://ce-41439.dp.appsmith.com

pratapaprasanna requested a review from a team as a code owner December 2, 2025 11:40

pratapaprasanna requested review from vivek-appsmith and removed request for a team December 2, 2025 11:40

github-actions bot added the Bug Something isn't working label Dec 2, 2025

vivek-appsmith requested review from ankitakinger and rahulbarwal and removed request for vivek-appsmith December 3, 2025 06:57

rahulbarwal approved these changes Dec 3, 2025

View reviewed changes

ankitakinger approved these changes Dec 3, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: update alt text for log icon and correct dropdown dependency (#4… #41439

fix: update alt text for log icon and correct dropdown dependency (#4… #41439

pratapaprasanna commented Dec 2, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Dec 2, 2025 •

edited

Loading

Uh oh!

pratapaprasanna commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: update alt text for log icon and correct dropdown dependency (#4… #41439

Are you sure you want to change the base?

fix: update alt text for log icon and correct dropdown dependency (#4… #41439

Conversation

pratapaprasanna commented Dec 2, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Automation

🔍 Cypress test results

Communication

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Pre-merge checks and finishing touches

Uh oh!

pratapaprasanna commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pratapaprasanna commented Dec 2, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 2, 2025 •

edited

Loading