WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@tomjose92
Copy link
Contributor

@tomjose92 tomjose92 commented Dec 5, 2025

Description

Added functionality behind a feature flag to configure logo icon width and height in Branding component
The changes for this will be reflected in the NavigationLogo in the ee repo

Fixes 41448

Automation

/ok-to-test tags=""

🔍 Cypress test results

Warning

Tests have not run on the HEAD 2f64d0b yet


Sat, 06 Dec 2025 05:02:12 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

…h and height in Branding component. The changes for this will be reflected in the NavigationLogo in the ee repo
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 5, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/issue-41448/branding-logo-dimensions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the Enhancement New feature or request label Dec 5, 2025
@tomjose92
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/19958681264.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 41449.
recreate: .

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Deploy-Preview-URL: https://ce-41449.dp.appsmith.com

@tomjose92 tomjose92 changed the title feat: added functionality behind a feature flag to configure logo icon width and height in Branding component feat: added functionality behind a feature flag to configure logo dimensions in Branding component Dec 5, 2025
@ankitakinger
Copy link
Contributor

/build-deploy-preview skip-tests=true

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/19962396493.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 41449.
recreate: .

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Deploy-Preview-URL: https://ce-41449.dp.appsmith.com

@tomjose92
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/19971508735.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 41449.
recreate: .

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Deploy-Preview-URL: https://ce-41449.dp.appsmith.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Allow configuration of Logo dimensions as part of Branding

2 participants