WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@Wachirawitch
Copy link

@Wachirawitch Wachirawitch commented Nov 10, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

GitHub issue reference:
Jira reference number [AR-9999]

Documentation summary for feature / change

Please delete this section if entry to main documentation is not needed.

If documentation entry is predicted, please provide key elements for further implementation into main documentation and set label to "Needs Documentation". You are welcome to open a PR to documentation or you can leave following information for technical writer:

  • short description (copy / paste of PR title)
  • summary (description relevant for end users)
  • example of usage (how to see this in function)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@github-actions
Copy link
Contributor

Hey @Wachirawitch! 👋

Thanks for submitting your first pull request to the Armbian project — we're excited to have you contributing! 🧡
Your effort doesn’t just improve Armbian — it benefits the entire community of users and developers.

If you'd like to stay informed about project updates or collaborate more closely with the team,
you can optionally share some personal contact preferences at armbian.com/update-data.
This helps us keep in touch without relying solely on GitHub notifications.

Also, don’t forget to ⭐ star the repo if you haven’t already — and welcome aboard! 🚀

@github-actions github-actions bot added Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Framework Framework components labels Nov 10, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 10, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces comprehensive partition management and build system enhancements for Armbian image creation. It disables git ignores for userpatches paths, adds debug information options to the kernel configuration, introduces three new shell scripts for partition formatting and rootfs injection, modifies partition selection logic in the core partitioning module, and adds userpatches customization configurations including a partition layout definition, example build config, image customization script, and custom partition hook extension.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45-60 minutes

  • userpatches/customize-image.sh: High complexity with multiple dense functions containing numerous OS-version-specific branches, external tool dependencies (apt, curl, xmlstarlet, debconf), and device-specific configurations (odroidxu4). Requires careful review of OMV installation flow, package management logic, and conditional branching.
  • lib/functions/image/partitioning.sh: Modification to core partition selection logic that forcibly overrides rootpart variable. Requires understanding of impact on partition layout calculations and downstream dependencies.
  • Partition handling script coordination: The new format-extra-partitions.sh, inject-rootfs.sh, and update-fstab.sh scripts work together in a pipeline; their interdependencies and error handling paths need cross-script validation.
  • .gitignore changes: Disabling ignores for userpatches paths alters git tracking behavior and may affect build reproducibility or CI workflows.
  • Custom partition extension integration: Review how custom_partition_hook.sh integrates with lib.config post-build hooks and partition.conf to ensure proper execution order and error handling.

Possibly related PRs

Suggested labels

Patches

Suggested reviewers

  • igorpecovnik
  • EvilOlaf
  • littlecxm
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between c133a7d and b9850fa.

📒 Files selected for processing (11)
  • .gitignore (1 hunks)
  • config/kernel/linux-rk35xx-vendor.config (1 hunks)
  • format-extra-partitions.sh (1 hunks)
  • inject-rootfs.sh (1 hunks)
  • lib/functions/image/partitioning.sh (1 hunks)
  • update-fstab.sh (1 hunks)
  • userpatches/config-example.conf (1 hunks)
  • userpatches/customize-image.sh (1 hunks)
  • userpatches/extensions/custom_partition_hook.sh (1 hunks)
  • userpatches/lib.config (1 hunks)
  • userpatches/partition.conf (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

11 Milestone: Fourth quarter release Framework Framework components Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review size/large PR with 250 lines or more

Development

Successfully merging this pull request may close these issues.

1 participant