WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Nov 12, 2025

Summary

This PR makes the Armbian MOTD consistent and modular regardless of which /etc/update-motd.d/* scripts are enabled.

Highlights

  • deterministic spacing: exactly one blank line appears before
  • move ip, AP and container info in separate script
  • vnStat formatting: drops decimals (205.88 MiB → 205 MiB) and ensures spacing between number and unit.
  • Temperature formatting: board/ambient temps truncated to integers (37.6°C → 37°C).
  • Tips compact: prints on its own line if something printed before; no trailing blank line; works even without jq or quotes.txt.
  • Containers spacing: prints no blank lines; only sets the “after-header” stamp for sysinfo.

How Has This Been Tested?

  • Manual tests displaying single and multiple items (driven via armbian-config)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 12, 2025

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • Needs review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch motd

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size/large PR with 250 lines or more 11 Milestone: Fourth quarter release Needs review Seeking for review BSP Board Support Packages labels Nov 12, 2025
@igorpecovnik igorpecovnik changed the title Consistent spacing with displaying MOTD elements Consistent spacing when displaying MOTD elements Nov 12, 2025
@igorpecovnik igorpecovnik changed the title Consistent spacing when displaying MOTD elements Cosmetic: consistent spacing when displaying MOTD Nov 12, 2025
@igorpecovnik igorpecovnik marked this pull request as ready for review November 12, 2025 17:01
@igorpecovnik igorpecovnik requested a review from a team as a code owner November 12, 2025 17:01
@SuperKali
Copy link
Member

Update: reviewing right now

@github-actions
Copy link
Contributor

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions bot added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Nov 15, 2025
@SuperKali
Copy link
Member

image

@SuperKali
Copy link
Member

@igorpecovnik all show correctly except ap-info

@igorpecovnik
Copy link
Member Author

ap-info

That is present only if AP runs on it, not in STA mode.

@igorpecovnik igorpecovnik merged commit b21d883 into main Nov 15, 2025
12 checks passed
@igorpecovnik igorpecovnik deleted the motd branch November 15, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

11 Milestone: Fourth quarter release BSP Board Support Packages Ready to merge Reviewed, tested and ready for merge size/large PR with 250 lines or more

Development

Successfully merging this pull request may close these issues.

3 participants