maint: cleanup board config files #8929

EvilOlaf · 2025-11-13T05:29:22Z

Description

went through all board config files
remove a couple of repetitive comments everyone seen forever or - from my guts feel - no longer relevant
- feel free to re-add if in doubt
simplify logic of some functions

How Has This Been Tested?

hasn't since mostly cosmetics

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

Chores
- Cleaned up inline comments and documentation across board configuration files for improved code maintainability.
- Updated boot configuration formatting for consistency across multiple board profiles.
- Refined device metadata and descriptions for better clarity.
Bug Fixes
- Fixed boot filesystem handling for specific board configurations.
- Adjusted boot target order for improved device initialization on select boards.

…ed to unset.

coderabbitai · 2025-11-13T05:29:27Z

Walkthrough

Systematic cleanup across 40+ board configuration files, primarily removing inline comments from U-Boot variable declarations (BOOTSOURCE, BOOTDELAY, BOOTDIR, BOOTCONFIG) and reformatting comment text, with functional updates to boot configuration logic in nanopi-r3s, dshanpi-r1, rock-3a, and youyeetoo-r1-v3.

Changes

Cohort / File(s)	Summary
Comment removal from BOOT variable declarations `config/boards/9tripod-x3568-v4.csc`, `config/boards/cherryba-m1.csc`, `config/boards/khadas-edge2.conf`, `config/boards/lckfb-taishanpi.csc`, `config/boards/longanpi-3h.csc`, `config/boards/lubancat2.csc`, `config/boards/mixtile-edge2.csc`, `config/boards/mksklipad50.conf`, `config/boards/orangepi5-max.csc`, `config/boards/quartz64a.csc`, `config/boards/quartz64b.csc`, `config/boards/radxa-zero.conf`, `config/boards/radxa-zero2.csc`, `config/boards/rock-5b-plus.conf`, `config/boards/rock-s0.conf`, `config/boards/station-m1.csc`	Removed inline comments from BOOTSOURCE, BOOTDELAY, BOOTDIR, and BOOTCONFIG declarations; values and logic unchanged
Comment rewrapping `config/boards/bananapim5pro.conf`, `config/boards/bananapim7.conf`	Split long comment lines into multiple lines while preserving original meaning
Comment removal + declaration cleanup `config/boards/bigtreetech-cb2.conf`, `config/boards/cm3588-nas.csc`, `config/boards/coolpi-genbook.csc`, `config/boards/jetson-nano.csc`, `config/boards/mixtile-blade3.csc`, `config/boards/nanopi-m6.conf`, `config/boards/nanopi-r6s.conf`, `config/boards/odroidm1.conf`, `config/boards/odroidm1s.csc`, `config/boards/orangepi3b.csc`, `config/boards/orangepi5-plus.conf`, `config/boards/orangepi5.conf`, `config/boards/rock-5b.conf`, `config/boards/tinkerboard-2.csc`	Removed multiple inline comments from BOOT-related declarations; removed commented-out configuration lines and Vim modelines
Commented line removal `config/boards/cainiao-cniot-core.csc`, `config/boards/inovato-quadra.conf`, `config/boards/jethubj200.conf`, `config/boards/nanopi-r3s-lts.conf`, `config/boards/nanopim4v2.conf`, `config/boards/rock-3a.conf`, `config/boards/rockpi-s.conf`	Removed commented-out configuration lines and comment metadata; removed unset directives for BOOTFS_TYPE in rock-3a.conf
Functional changes to boot configuration `config/boards/dshanpi-r1.csc`	Removed unconditional unset of BOOTFS_TYPE; removed inline comment from BOOTDIR assignment
Early-return guard + new variables `config/boards/nanopi-r3s.csc`	Added vendor BRANCH early-return guard in post_family_config__use_mainline_uboot; added BOOTPATCHDIR (v2025.04) and UBOOT_TARGET_MAP variables with BL31/ROCKCHIP_TPL mappings
Complex boot order refactoring `config/boards/youyeetoo-r1-v3.csc`	Removed post_family_config__youyeetoo-r1-v3_auto_dtb_name_via_uboot_detection() function; added explicit BOOT_FDT_FILE unset; changed boot target order from mmc1-first to mmc0-first via pre_config_uboot_target__youyeetoo_r1_patch_rockchip_common_boot_order()
Comment addition `config/boards/xiaomi-elish.conf`	Added single hardware description comment line
Whitespace/alignment adjustment `config/boards/mekotronics-r58-4x4.conf`	Minor whitespace change on BOOT_FDT_FILE declaration; value unchanged

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Areas requiring extra attention:

config/boards/nanopi-r3s.csc — vendor BRANCH early-return guard logic and new variable initialization
config/boards/youyeetoo-r1-v3.csc — function removal and boot target order patching through pre_config_uboot_target hook
config/boards/dshanpi-r1.csc and config/boards/rock-3a.conf — removal of BOOTFS_TYPE unset directives and their impact on boot filesystem defaults
High-count files with multiple comment removals (config/boards/nanopi-m6.conf, config/boards/orangepi5.conf, config/boards/rock-5b.conf) — verify consistency and no accidental value changes

Possibly related PRs

nanopi-r3s, radxa-zero3, rock-3a: board config cleanup & maint #8045 — Modifies nanopi-r3s.csc with BOOTPATCHDIR and UBOOT_TARGET_MAP initialization, directly overlapping with functional changes in this PR
board: youyeetoo-r1: correct minor typo on the config #8817 — Updates youyeetoo-r1-v3.csc boot order and mainline U-Boot configuration logic, intersecting with boot target patching in this PR
nanopi-r3s: bump uboot to v2025.04 #8070 — Sets BOOTPATCHDIR variable in nanopi-r3s.csc, related to new variable additions in this PR

Suggested reviewers

igorpecovnik
rpardini
amazingfate
pyavitz

Poem

🐰 Hops through configs with glee,
Comments trimmed, clean as can be,
Boot orders dance, vendors now gleam,
Cleanup complete—the perfect team! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'maint: cleanup board config files' accurately summarizes the main objective of the PR—systematic cleanup and refactoring of board configuration files by removing comments and simplifying logic.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between ebc129f and 247777d.

📒 Files selected for processing (45)

config/boards/9tripod-x3568-v4.csc (1 hunks)
config/boards/bananapim5pro.conf (1 hunks)
config/boards/bananapim7.conf (1 hunks)
config/boards/bigtreetech-cb2.conf (1 hunks)
config/boards/cainiao-cniot-core.csc (1 hunks)
config/boards/cherryba-m1.csc (1 hunks)
config/boards/cm3588-nas.csc (1 hunks)
config/boards/coolpi-genbook.csc (1 hunks)
config/boards/dshanpi-r1.csc (1 hunks)
config/boards/inovato-quadra.conf (0 hunks)
config/boards/jethubj200.conf (0 hunks)
config/boards/jetson-nano.csc (0 hunks)
config/boards/khadas-edge2.conf (1 hunks)
config/boards/lckfb-taishanpi.csc (1 hunks)
config/boards/longanpi-3h.csc (1 hunks)
config/boards/lubancat2.csc (1 hunks)
config/boards/mekotronics-r58-4x4.conf (1 hunks)
config/boards/mixtile-blade3.csc (1 hunks)
config/boards/mixtile-edge2.csc (1 hunks)
config/boards/mksklipad50.conf (1 hunks)
config/boards/nanopct6.conf (1 hunks)
config/boards/nanopi-m6.conf (1 hunks)
config/boards/nanopi-r3s-lts.conf (1 hunks)
config/boards/nanopi-r3s.csc (1 hunks)
config/boards/nanopi-r6s.conf (1 hunks)
config/boards/nanopim4v2.conf (1 hunks)
config/boards/odroidm1.conf (1 hunks)
config/boards/odroidm1s.csc (1 hunks)
config/boards/orangepi3b.csc (1 hunks)
config/boards/orangepi5-max.csc (1 hunks)
config/boards/orangepi5-plus.conf (1 hunks)
config/boards/orangepi5.conf (1 hunks)
config/boards/quartz64a.csc (1 hunks)
config/boards/quartz64b.csc (1 hunks)
config/boards/radxa-zero.conf (0 hunks)
config/boards/radxa-zero2.csc (0 hunks)
config/boards/rock-3a.conf (1 hunks)
config/boards/rock-5b-plus.conf (1 hunks)
config/boards/rock-5b.conf (1 hunks)
config/boards/rock-s0.conf (0 hunks)
config/boards/rockpi-s.conf (0 hunks)
config/boards/station-m1.csc (1 hunks)
config/boards/tinkerboard-2.csc (1 hunks)
config/boards/xiaomi-elish.conf (1 hunks)
config/boards/youyeetoo-r1-v3.csc (1 hunks)

💤 Files with no reviewable changes (7)

config/boards/inovato-quadra.conf
config/boards/rockpi-s.conf
config/boards/rock-s0.conf
config/boards/jetson-nano.csc
config/boards/radxa-zero.conf
config/boards/radxa-zero2.csc
config/boards/jethubj200.conf

🧰 Additional context used

🧠 Learnings (42)

📓 Common learnings

Learnt from: EvilOlaf
Repo: armbian/build PR: 8428
File: config/boards/lckfb-taishanpi.csc:5-9
Timestamp: 2025-07-25T03:51:50.830Z
Learning: When reviewing PRs in the Armbian build system, U-Boot defconfig files and patches may be added as part of the PR changes but might not be visible in the current repository clone state during review. It's important to check the actual PR file changes directly via GitHub API (https://api.github.com/repos/armbian/build/pulls/{pr_number}/files) to get the complete picture of what files are being added or modified, especially for U-Boot patches that will be applied during the build process.

Learnt from: EvilOlaf
Repo: armbian/build PR: 8428
File: config/boards/lckfb-taishanpi.csc:5-9
Timestamp: 2025-07-25T03:51:50.830Z
Learning: When reviewing PRs in the Armbian build system, U-Boot defconfig files and patches may be added as part of the PR changes but might not be visible in the current repository clone state during review. It's important to check the actual PR file changes directly via GitHub or the PR API to get the complete picture of what files are being added or modified.

Learnt from: EvilOlaf
Repo: armbian/build PR: 8537
File: config/boards/qcom-robotics-rb5.conf:1-1
Timestamp: 2025-09-18T03:36:17.862Z
Learning: In Armbian board configuration files, .wip and .conf extensions require BOARD_MAINTAINER to be present and contain at least one maintainer. If no maintainer is present, the board support rules state it does not qualify for standard support and must be moved to community support (.csc extension). This is documented at https://docs.armbian.com/User-Guide_Board-Support-Rules/

Learnt from: igorpecovnik
Repo: armbian/build PR: 8705
File: .github/workflows/rewrite-kernel-configs.yml:96-169
Timestamp: 2025-10-03T11:42:46.660Z
Learning: In the Armbian build repository's kernel config rewrite workflow (.github/workflows/rewrite-kernel-configs.yml), deletion of kernel config files does not need to be handled. The workflow intentionally only captures ACMR (added/copied/modified/renamed) changes and does not need to propagate deletions to the aggregator.

Learnt from: pyavitz
Repo: armbian/build PR: 8388
File: config/boards/kickpik2b.conf:1-14
Timestamp: 2025-07-17T04:12:33.125Z
Learning: In the Armbian build system, board configuration files (*.conf) follow a project standard of not including shebang lines, even though they contain bash code and are sourced by the build system. This is an established Armbian convention that individual contributors are expected to follow, and changes to this standard would require broader project maintainer approval.

Learnt from: igorpecovnik
Repo: armbian/build PR: 8849
File: config/boards/radxa-e54c.csc:14-28
Timestamp: 2025-11-02T20:49:56.719Z
Learning: In Armbian board configuration files (config/boards/*.conf, *.csc, etc.), do not use kernel_config_set, kernel_config_set_m, kernel_config_set_y, or custom_kernel_config__* functions to modify kernel configuration. Kernel configuration is associated with LINUXFAMILY/BOARDFAMILY, not individual BOARD. Board-specific kernel modifications cause inconsistency in kernel packages published to the apt repository because boards within a family share the same kernel packages. Kernel configuration changes must be made in the appropriate kernel config file (e.g., config/kernel/linux-*-*.config) or in family configuration files (config/sources/families/*.conf, *.inc) instead.

Learnt from: rpardini
Repo: armbian/build PR: 8044
File: patch/u-boot/v2025.04/cmd-fileenv-read-string-from-file-into-env.patch:76-86
Timestamp: 2025-03-31T22:20:48.475Z
Learning: For the Armbian build project, maintaining consistency with existing patches across U-Boot versions (such as between 2025.01 and 2025.04) is prioritized over refactoring individual patches for code improvements.

Learnt from: EvilOlaf
Repo: armbian/build PR: 8537
File: config/boards/qcom-robotics-rb5.conf:1-1
Timestamp: 2025-09-18T03:36:17.862Z
Learning: In Armbian board configuration files (regardless of file extension), the standard pattern is to have only one line as a comment describing the board hardware specifications. This single-line description typically includes the SoC model, core count, RAM options, and key features like connectivity options, storage interfaces, and special features. The file extensions indicate board support status: .conf (standard support), .csc (community supported), .eos (end of support), .tvb (tvbox), .wip (work in progress).

Learnt from: EvilOlaf
Repo: armbian/build PR: 0
File: :0-0
Timestamp: 2025-07-21T04:12:02.439Z
Learning: In the Armbian build system, for recurring maintenance tasks like kernel version bumping, TODO comments should use generic version formats (e.g., "MAJOR.MINOR-rc1") rather than specific version numbers (e.g., "6.17-rc1") to avoid the need for frequent comment updates that would create unnecessary maintenance overhead.

Learnt from: amazingfate
Repo: armbian/build PR: 8619
File: config/sources/families/rockchip.conf:222-230
Timestamp: 2025-09-14T06:32:29.806Z
Learning: In the Armbian build system, the write_uboot_platform() function implementations follow different patterns across Rockchip family files. The newer standard (used in rockchip64_common.inc and rk3506) includes 'status=none' parameter in dd commands, while older implementations (rk3288, rk322x) use an older pattern without this parameter. The rk3506 implementation correctly follows the current Rockchip family standard.

Learnt from: rpardini
Repo: armbian/build PR: 8044
File: patch/u-boot/v2025.04/cmd-fileenv-read-string-from-file-into-env.patch:73-75
Timestamp: 2025-03-31T22:20:41.849Z
Learning: When porting patches between U-Boot versions (like from 2025.01 to 2025.04), rpardini prefers to maintain patches as-is rather than introducing refactoring changes, even when potential improvements are identified. This approach prioritizes consistency and reduces the risk of introducing new issues.

Learnt from: SuperKali
Repo: armbian/build PR: 8609
File: config/boards/nanopi-r76s.conf:5-5
Timestamp: 2025-09-11T06:16:10.236Z
Learning: In Armbian board configuration files, WIP (Work In Progress) comments describe intended goals or planned features rather than current implementation state. For example, a comment like "WIP: current kernel" indicates that current kernel support is being worked toward, even if KERNEL_TARGET doesn't yet include "current".

Learnt from: tabrisnet
Repo: armbian/build PR: 0
File: :0-0
Timestamp: 2025-08-30T04:13:16.457Z
Learning: Armbian kernel configuration files like linux-filogic-current.config are autogenerated overlays on top of arch defconfig. Comments added manually will be lost during future updates by maintainers, and explicit "CONFIG_OPTION is not set" statements aren't needed for mutually exclusive options since these are overlay configs that only specify changes from the base configuration.

Learnt from: EvilOlaf
Repo: armbian/build PR: 8586
File: config/boards/nanopi-r76s.conf:15-21
Timestamp: 2025-09-07T17:39:32.272Z
Learning: In the Armbian build system, the variables $BOARD and $SDCARD are always set by the build framework, so guard checks for these variables are unnecessary in board configuration files and hook functions.

📚 Learning: 2025-10-14T05:08:11.785Z

Learnt from: EvilOlaf
Repo: armbian/build PR: 8754
File: config/boards/bestv-r3300-l.csc:14-16
Timestamp: 2025-10-14T05:08:11.785Z
Learning: In the Armbian build system, BOOTBRANCH_BOARD is a valid framework variable used as a fallback when BOOTBRANCH is unset. The framework checks BOOTBRANCH_BOARD before applying the default bootloader branch value (see config/sources/common.conf). Board configuration files can use BOOTBRANCH_BOARD to specify the bootloader branch.

Applied to files:

config/boards/tinkerboard-2.csc
config/boards/nanopi-r3s-lts.conf
config/boards/cherryba-m1.csc
config/boards/lckfb-taishanpi.csc
config/boards/mksklipad50.conf
config/boards/mekotronics-r58-4x4.conf
config/boards/bananapim7.conf
config/boards/bigtreetech-cb2.conf
config/boards/bananapim5pro.conf
config/boards/cainiao-cniot-core.csc
config/boards/nanopim4v2.conf
config/boards/cm3588-nas.csc
config/boards/rock-3a.conf
config/boards/quartz64a.csc
config/boards/odroidm1.conf
config/boards/coolpi-genbook.csc
config/boards/longanpi-3h.csc
config/boards/dshanpi-r1.csc
config/boards/9tripod-x3568-v4.csc
config/boards/khadas-edge2.conf
config/boards/station-m1.csc
config/boards/lubancat2.csc
config/boards/nanopi-r6s.conf
config/boards/orangepi5-max.csc
config/boards/quartz64b.csc
config/boards/nanopi-m6.conf
config/boards/nanopi-r3s.csc
config/boards/rock-5b.conf
config/boards/orangepi5.conf
config/boards/mixtile-edge2.csc
config/boards/odroidm1s.csc
config/boards/rock-5b-plus.conf
config/boards/nanopct6.conf
config/boards/youyeetoo-r1-v3.csc
config/boards/orangepi5-plus.conf
config/boards/mixtile-blade3.csc
config/boards/orangepi3b.csc

📚 Learning: 2025-09-18T03:36:17.862Z

Learnt from: EvilOlaf
Repo: armbian/build PR: 8537
File: config/boards/qcom-robotics-rb5.conf:1-1
Timestamp: 2025-09-18T03:36:17.862Z
Learning: In Armbian board configuration files (regardless of file extension), the standard pattern is to have only one line as a comment describing the board hardware specifications. This single-line description typically includes the SoC model, core count, RAM options, and key features like connectivity options, storage interfaces, and special features. The file extensions indicate board support status: .conf (standard support), .csc (community supported), .eos (end of support), .tvb (tvbox), .wip (work in progress).

Applied to files:

config/boards/tinkerboard-2.csc
config/boards/nanopi-r3s-lts.conf
config/boards/cherryba-m1.csc
config/boards/lckfb-taishanpi.csc
config/boards/mksklipad50.conf
config/boards/mekotronics-r58-4x4.conf
config/boards/bananapim7.conf
config/boards/bigtreetech-cb2.conf
config/boards/bananapim5pro.conf
config/boards/cainiao-cniot-core.csc
config/boards/nanopim4v2.conf
config/boards/xiaomi-elish.conf
config/boards/cm3588-nas.csc
config/boards/rock-3a.conf
config/boards/quartz64a.csc
config/boards/odroidm1.conf
config/boards/longanpi-3h.csc
config/boards/dshanpi-r1.csc
config/boards/khadas-edge2.conf
config/boards/nanopi-r6s.conf
config/boards/orangepi5-max.csc
config/boards/quartz64b.csc
config/boards/nanopi-m6.conf
config/boards/rock-5b.conf
config/boards/orangepi5.conf
config/boards/mixtile-edge2.csc
config/boards/odroidm1s.csc
config/boards/rock-5b-plus.conf
config/boards/nanopct6.conf
config/boards/youyeetoo-r1-v3.csc
config/boards/orangepi5-plus.conf
config/boards/orangepi3b.csc

📚 Learning: 2025-11-02T20:49:56.719Z

Learnt from: igorpecovnik
Repo: armbian/build PR: 8849
File: config/boards/radxa-e54c.csc:14-28
Timestamp: 2025-11-02T20:49:56.719Z
Learning: In Armbian board configuration files (config/boards/*.conf, *.csc, etc.), do not use kernel_config_set, kernel_config_set_m, kernel_config_set_y, or custom_kernel_config__* functions to modify kernel configuration. Kernel configuration is associated with LINUXFAMILY/BOARDFAMILY, not individual BOARD. Board-specific kernel modifications cause inconsistency in kernel packages published to the apt repository because boards within a family share the same kernel packages. Kernel configuration changes must be made in the appropriate kernel config file (e.g., config/kernel/linux-*-*.config) or in family configuration files (config/sources/families/*.conf, *.inc) instead.

Applied to files:

config/boards/tinkerboard-2.csc
config/boards/nanopi-r3s-lts.conf
config/boards/cherryba-m1.csc
config/boards/lckfb-taishanpi.csc
config/boards/mksklipad50.conf
config/boards/mekotronics-r58-4x4.conf
config/boards/bananapim7.conf
config/boards/bigtreetech-cb2.conf
config/boards/bananapim5pro.conf
config/boards/cainiao-cniot-core.csc
config/boards/nanopim4v2.conf
config/boards/cm3588-nas.csc
config/boards/rock-3a.conf
config/boards/quartz64a.csc
config/boards/odroidm1.conf
config/boards/coolpi-genbook.csc
config/boards/longanpi-3h.csc
config/boards/dshanpi-r1.csc
config/boards/9tripod-x3568-v4.csc
config/boards/khadas-edge2.conf
config/boards/station-m1.csc
config/boards/lubancat2.csc
config/boards/nanopi-r6s.conf
config/boards/orangepi5-max.csc
config/boards/quartz64b.csc
config/boards/nanopi-m6.conf
config/boards/nanopi-r3s.csc
config/boards/rock-5b.conf
config/boards/orangepi5.conf
config/boards/mixtile-edge2.csc
config/boards/odroidm1s.csc
config/boards/rock-5b-plus.conf
config/boards/nanopct6.conf
config/boards/youyeetoo-r1-v3.csc
config/boards/orangepi5-plus.conf
config/boards/mixtile-blade3.csc
config/boards/orangepi3b.csc

📚 Learning: 2025-07-17T04:12:33.125Z

Learnt from: pyavitz
Repo: armbian/build PR: 8388
File: config/boards/kickpik2b.conf:1-14
Timestamp: 2025-07-17T04:12:33.125Z
Learning: In the Armbian build system, board configuration files (*.conf) follow a project standard of not including shebang lines, even though they contain bash code and are sourced by the build system. This is an established Armbian convention that individual contributors are expected to follow, and changes to this standard would require broader project maintainer approval.

Applied to files:

config/boards/tinkerboard-2.csc
config/boards/nanopi-r3s-lts.conf
config/boards/lckfb-taishanpi.csc
config/boards/mksklipad50.conf
config/boards/mekotronics-r58-4x4.conf
config/boards/bananapim7.conf
config/boards/bigtreetech-cb2.conf
config/boards/bananapim5pro.conf
config/boards/nanopim4v2.conf
config/boards/cm3588-nas.csc
config/boards/rock-3a.conf
config/boards/odroidm1.conf
config/boards/longanpi-3h.csc
config/boards/dshanpi-r1.csc
config/boards/khadas-edge2.conf
config/boards/nanopi-r6s.conf
config/boards/orangepi5-max.csc
config/boards/nanopi-m6.conf
config/boards/rock-5b.conf
config/boards/orangepi5.conf
config/boards/odroidm1s.csc
config/boards/rock-5b-plus.conf
config/boards/nanopct6.conf
config/boards/orangepi5-plus.conf
config/boards/orangepi3b.csc

📚 Learning: 2025-07-21T04:12:02.439Z

Learnt from: EvilOlaf
Repo: armbian/build PR: 0
File: :0-0
Timestamp: 2025-07-21T04:12:02.439Z
Learning: In the Armbian build system, for recurring maintenance tasks like kernel version bumping, TODO comments should use generic version formats (e.g., "MAJOR.MINOR-rc1") rather than specific version numbers (e.g., "6.17-rc1") to avoid the need for frequent comment updates that would create unnecessary maintenance overhead.

Applied to files:

config/boards/tinkerboard-2.csc
config/boards/cherryba-m1.csc
config/boards/cainiao-cniot-core.csc
config/boards/cm3588-nas.csc
config/boards/nanopi-r6s.conf
config/boards/orangepi5-max.csc
config/boards/nanopi-m6.conf
config/boards/odroidm1s.csc
config/boards/rock-5b-plus.conf
config/boards/nanopct6.conf

📚 Learning: 2025-09-18T03:36:17.862Z

Learnt from: EvilOlaf
Repo: armbian/build PR: 8537
File: config/boards/qcom-robotics-rb5.conf:1-1
Timestamp: 2025-09-18T03:36:17.862Z
Learning: In Armbian board configuration files, .wip and .conf extensions require BOARD_MAINTAINER to be present and contain at least one maintainer. If no maintainer is present, the board support rules state it does not qualify for standard support and must be moved to community support (.csc extension). This is documented at https://docs.armbian.com/User-Guide_Board-Support-Rules/

Applied to files:

config/boards/tinkerboard-2.csc
config/boards/nanopi-r3s-lts.conf
config/boards/mksklipad50.conf
config/boards/mekotronics-r58-4x4.conf
config/boards/bananapim7.conf
config/boards/nanopim4v2.conf
config/boards/orangepi5.conf
config/boards/rock-5b-plus.conf
config/boards/youyeetoo-r1-v3.csc
config/boards/orangepi5-plus.conf

📚 Learning: 2025-06-12T21:14:36.024Z

Learnt from: djurny
Repo: armbian/build PR: 8287
File: config/bootscripts/boot-sunxi.cmd:38-44
Timestamp: 2025-06-12T21:14:36.024Z
Learning: In config/bootscripts/boot-sunxi.cmd the unconditional "+1" increment in func_align_addr_next (when align_overlap_oboe_avoidance="on") is intentional. It compensates for a known off-by-one error in U-Boot where the end address is calculated as start+size instead of start+size-1, so the extra page prevents overlap. This behavior should not be “optimized away”.

Applied to files:

config/boards/tinkerboard-2.csc
config/boards/lckfb-taishanpi.csc
config/boards/mekotronics-r58-4x4.conf
config/boards/coolpi-genbook.csc
config/boards/longanpi-3h.csc
config/boards/9tripod-x3568-v4.csc
config/boards/orangepi5-max.csc
config/boards/odroidm1s.csc

📚 Learning: 2025-09-07T17:39:32.272Z

Learnt from: EvilOlaf
Repo: armbian/build PR: 8586
File: config/boards/nanopi-r76s.conf:15-21
Timestamp: 2025-09-07T17:39:32.272Z
Learning: In the Armbian build system, the variables $BOARD and $SDCARD are always set by the build framework, so guard checks for these variables are unnecessary in board configuration files and hook functions.

Applied to files:

config/boards/tinkerboard-2.csc
config/boards/lckfb-taishanpi.csc
config/boards/mekotronics-r58-4x4.conf
config/boards/bananapim7.conf
config/boards/bigtreetech-cb2.conf
config/boards/bananapim5pro.conf
config/boards/rock-3a.conf
config/boards/longanpi-3h.csc
config/boards/dshanpi-r1.csc
config/boards/9tripod-x3568-v4.csc
config/boards/khadas-edge2.conf
config/boards/nanopi-r6s.conf
config/boards/quartz64b.csc
config/boards/nanopi-m6.conf
config/boards/nanopi-r3s.csc
config/boards/mixtile-edge2.csc
config/boards/odroidm1s.csc
config/boards/rock-5b-plus.conf
config/boards/nanopct6.conf
config/boards/orangepi5-plus.conf
config/boards/mixtile-blade3.csc

📚 Learning: 2025-08-02T05:46:10.664Z

Learnt from: EvilOlaf
Repo: armbian/build PR: 0
File: :0-0
Timestamp: 2025-08-02T05:46:10.664Z
Learning: In the Armbian build system, the modern recommended approach for kernel configuration is to use the kernel-config command via "./compile.sh BOARD=boardname BRANCH=branchname kernel-config" instead of the deprecated KERNEL_CONFIGURE=yes flag. This provides a two-step workflow: configure using menuconfig, then build, with better transparency and control over configuration changes.

Applied to files:

config/boards/tinkerboard-2.csc
config/boards/nanopi-r3s-lts.conf
config/boards/cherryba-m1.csc
config/boards/cm3588-nas.csc
config/boards/rock-3a.conf
config/boards/quartz64a.csc
config/boards/longanpi-3h.csc
config/boards/dshanpi-r1.csc
config/boards/9tripod-x3568-v4.csc
config/boards/khadas-edge2.conf
config/boards/station-m1.csc
config/boards/lubancat2.csc
config/boards/nanopi-r6s.conf
config/boards/orangepi5-max.csc
config/boards/quartz64b.csc
config/boards/nanopi-m6.conf
config/boards/nanopi-r3s.csc
config/boards/rock-5b.conf
config/boards/mixtile-edge2.csc
config/boards/odroidm1s.csc
config/boards/rock-5b-plus.conf
config/boards/orangepi5-plus.conf
config/boards/orangepi3b.csc

📚 Learning: 2025-09-12T19:28:38.491Z

Learnt from: Grippy98
Repo: armbian/build PR: 8622
File: config/sources/families/k3.conf:66-66
Timestamp: 2025-09-12T19:28:38.491Z
Learning: In the Armbian k3 family build system (config/sources/families/k3.conf), builds do not fail when TIBOOT3_BOOTCONFIG is unset, even though tiboot3.bin is still listed in UBOOT_TARGET_MAP. The gating mechanism in pre_config_uboot_target__build_first_stage function works as intended to conditionally build/copy tiboot3.bin only when TIBOOT3_BOOTCONFIG is defined.

Applied to files:

config/boards/tinkerboard-2.csc
config/boards/nanopi-r3s-lts.conf
config/boards/cherryba-m1.csc
config/boards/lckfb-taishanpi.csc
config/boards/mksklipad50.conf
config/boards/bigtreetech-cb2.conf
config/boards/cainiao-cniot-core.csc
config/boards/cm3588-nas.csc
config/boards/rock-3a.conf
config/boards/quartz64a.csc
config/boards/odroidm1.conf
config/boards/coolpi-genbook.csc
config/boards/longanpi-3h.csc
config/boards/dshanpi-r1.csc
config/boards/9tripod-x3568-v4.csc
config/boards/khadas-edge2.conf
config/boards/station-m1.csc
config/boards/lubancat2.csc
config/boards/nanopi-r6s.conf
config/boards/orangepi5-max.csc
config/boards/quartz64b.csc
config/boards/nanopi-m6.conf
config/boards/nanopi-r3s.csc
config/boards/rock-5b.conf
config/boards/orangepi5.conf
config/boards/mixtile-edge2.csc
config/boards/odroidm1s.csc
config/boards/rock-5b-plus.conf
config/boards/nanopct6.conf
config/boards/youyeetoo-r1-v3.csc
config/boards/orangepi5-plus.conf
config/boards/mixtile-blade3.csc
config/boards/orangepi3b.csc

📚 Learning: 2025-07-23T07:30:52.265Z

Learnt from: EvilOlaf
Repo: armbian/build PR: 8417
File: config/boards/orangepi5pro.csc:57-58
Timestamp: 2025-07-23T07:30:52.265Z
Learning: In the Armbian build system, BOOTPATCHDIR can contain board-specific subdirectories (e.g., board_orangepi5pro) for applying patches to specific boards only. The framework automatically checks if such board-specific subdirectories exist for the board being built and applies those patches accordingly.

Applied to files:

config/boards/tinkerboard-2.csc
config/boards/cherryba-m1.csc
config/boards/lckfb-taishanpi.csc
config/boards/mksklipad50.conf
config/boards/bigtreetech-cb2.conf
config/boards/cainiao-cniot-core.csc
config/boards/cm3588-nas.csc
config/boards/rock-3a.conf
config/boards/quartz64a.csc
config/boards/odroidm1.conf
config/boards/coolpi-genbook.csc
config/boards/longanpi-3h.csc
config/boards/dshanpi-r1.csc
config/boards/9tripod-x3568-v4.csc
config/boards/khadas-edge2.conf
config/boards/station-m1.csc
config/boards/lubancat2.csc
config/boards/nanopi-r6s.conf
config/boards/orangepi5-max.csc
config/boards/quartz64b.csc
config/boards/nanopi-m6.conf
config/boards/nanopi-r3s.csc
config/boards/rock-5b.conf
config/boards/orangepi5.conf
config/boards/mixtile-edge2.csc
config/boards/odroidm1s.csc
config/boards/rock-5b-plus.conf
config/boards/nanopct6.conf
config/boards/orangepi5-plus.conf
config/boards/mixtile-blade3.csc
config/boards/orangepi3b.csc

📚 Learning: 2025-10-26T10:41:35.118Z

Learnt from: HackingGate
Repo: armbian/build PR: 8665
File: config/boards/photonicat2.csc:4-4
Timestamp: 2025-10-26T10:41:35.118Z
Learning: In the Armbian build system, rk3576 boards consistently use BOARDFAMILY="rk35xx" for both vendor and edge kernel targets. The rk35xx family configuration sources rockchip64_common.inc, which provides edge and current kernel branch definitions, making these branches available even though they're not defined directly in rk35xx.conf.

Applied to files:

config/boards/tinkerboard-2.csc
config/boards/nanopi-r3s-lts.conf
config/boards/cherryba-m1.csc
config/boards/lckfb-taishanpi.csc
config/boards/mksklipad50.conf
config/boards/mekotronics-r58-4x4.conf
config/boards/bananapim7.conf
config/boards/bigtreetech-cb2.conf
config/boards/bananapim5pro.conf
config/boards/cainiao-cniot-core.csc
config/boards/nanopim4v2.conf
config/boards/xiaomi-elish.conf
config/boards/cm3588-nas.csc
config/boards/rock-3a.conf
config/boards/quartz64a.csc
config/boards/odroidm1.conf
config/boards/coolpi-genbook.csc
config/boards/longanpi-3h.csc
config/boards/dshanpi-r1.csc
config/boards/9tripod-x3568-v4.csc
config/boards/khadas-edge2.conf
config/boards/station-m1.csc
config/boards/lubancat2.csc
config/boards/nanopi-r6s.conf
config/boards/orangepi5-max.csc
config/boards/quartz64b.csc
config/boards/nanopi-m6.conf
config/boards/nanopi-r3s.csc
config/boards/rock-5b.conf
config/boards/orangepi5.conf
config/boards/mixtile-edge2.csc
config/boards/odroidm1s.csc
config/boards/rock-5b-plus.conf
config/boards/nanopct6.conf
config/boards/youyeetoo-r1-v3.csc
config/boards/orangepi5-plus.conf
config/boards/mixtile-blade3.csc
config/boards/orangepi3b.csc

📚 Learning: 2025-09-14T06:29:18.958Z

Learnt from: amazingfate
Repo: armbian/build PR: 8619
File: config/sources/families/rockchip.conf:64-70
Timestamp: 2025-09-14T06:29:18.958Z
Learning: In the Armbian build system, vendor branch configurations in family files are designed to be shared across multiple SoCs within the same family that use the same vendor kernel tree. For example, rk35xx and rockchip-rk3588 families both use identical vendor branch settings (same KERNELSOURCE, KERNELBRANCH, and KERNELPATCHDIR), demonstrating that vendor branches are intentionally generic rather than SoC-specific.

Applied to files:

config/boards/tinkerboard-2.csc
config/boards/nanopi-r3s-lts.conf
config/boards/lckfb-taishanpi.csc
config/boards/mekotronics-r58-4x4.conf
config/boards/bananapim7.conf
config/boards/bananapim5pro.conf
config/boards/cainiao-cniot-core.csc
config/boards/nanopim4v2.conf
config/boards/cm3588-nas.csc
config/boards/rock-3a.conf
config/boards/quartz64a.csc
config/boards/dshanpi-r1.csc
config/boards/station-m1.csc
config/boards/nanopi-r6s.conf
config/boards/orangepi5-max.csc
config/boards/quartz64b.csc
config/boards/nanopi-m6.conf
config/boards/nanopi-r3s.csc
config/boards/rock-5b.conf
config/boards/orangepi5.conf
config/boards/odroidm1s.csc
config/boards/youyeetoo-r1-v3.csc
config/boards/orangepi5-plus.conf
config/boards/orangepi3b.csc

📚 Learning: 2025-03-31T22:20:48.475Z

Learnt from: rpardini
Repo: armbian/build PR: 8044
File: patch/u-boot/v2025.04/cmd-fileenv-read-string-from-file-into-env.patch:76-86
Timestamp: 2025-03-31T22:20:48.475Z
Learning: For the Armbian build project, maintaining consistency with existing patches across U-Boot versions (such as between 2025.01 and 2025.04) is prioritized over refactoring individual patches for code improvements.

Applied to files:

config/boards/tinkerboard-2.csc
config/boards/cherryba-m1.csc
config/boards/lckfb-taishanpi.csc
config/boards/mksklipad50.conf
config/boards/cainiao-cniot-core.csc
config/boards/cm3588-nas.csc
config/boards/odroidm1.conf
config/boards/coolpi-genbook.csc
config/boards/longanpi-3h.csc
config/boards/9tripod-x3568-v4.csc
config/boards/lubancat2.csc
config/boards/nanopi-r6s.conf
config/boards/orangepi5-max.csc
config/boards/nanopi-m6.conf
config/boards/nanopi-r3s.csc
config/boards/rock-5b.conf
config/boards/orangepi5.conf
config/boards/mixtile-edge2.csc
config/boards/odroidm1s.csc
config/boards/rock-5b-plus.conf
config/boards/youyeetoo-r1-v3.csc
config/boards/orangepi5-plus.conf
config/boards/orangepi3b.csc

📚 Learning: 2025-09-14T06:32:29.806Z

Learnt from: amazingfate
Repo: armbian/build PR: 8619
File: config/sources/families/rockchip.conf:222-230
Timestamp: 2025-09-14T06:32:29.806Z
Learning: In the Armbian build system, the write_uboot_platform() function implementations follow different patterns across Rockchip family files. The newer standard (used in rockchip64_common.inc and rk3506) includes 'status=none' parameter in dd commands, while older implementations (rk3288, rk322x) use an older pattern without this parameter. The rk3506 implementation correctly follows the current Rockchip family standard.

Applied to files:

config/boards/tinkerboard-2.csc
config/boards/nanopi-r3s-lts.conf
config/boards/lckfb-taishanpi.csc
config/boards/mksklipad50.conf
config/boards/mekotronics-r58-4x4.conf
config/boards/bigtreetech-cb2.conf
config/boards/nanopim4v2.conf
config/boards/cm3588-nas.csc
config/boards/rock-3a.conf
config/boards/quartz64a.csc
config/boards/odroidm1.conf
config/boards/coolpi-genbook.csc
config/boards/longanpi-3h.csc
config/boards/dshanpi-r1.csc
config/boards/9tripod-x3568-v4.csc
config/boards/khadas-edge2.conf
config/boards/station-m1.csc
config/boards/nanopi-r6s.conf
config/boards/orangepi5-max.csc
config/boards/quartz64b.csc
config/boards/nanopi-m6.conf
config/boards/nanopi-r3s.csc
config/boards/rock-5b.conf
config/boards/orangepi5.conf
config/boards/mixtile-edge2.csc
config/boards/odroidm1s.csc
config/boards/rock-5b-plus.conf
config/boards/nanopct6.conf
config/boards/youyeetoo-r1-v3.csc
config/boards/orangepi5-plus.conf
config/boards/mixtile-blade3.csc
config/boards/orangepi3b.csc

📚 Learning: 2025-11-10T22:05:40.490Z

Learnt from: tabrisnet
Repo: armbian/build PR: 8913
File: config/sources/families/k3-beagle.conf:16-16
Timestamp: 2025-11-10T22:05:40.490Z
Learning: In the Armbian build system, kernel branches using non-mainline/vendor forks (like BeagleBoard's linux repository) should be named "vendor" or "vendor-rt" rather than "current" or "edge". The "current" and "edge" naming is reserved for mainline kernel branches. This affects both the case statement in family config files (e.g., `vendor | vendor-rt)` instead of `current | current-rt)`) and the corresponding KERNEL_TARGET declarations in board config files.

Applied to files:

config/boards/tinkerboard-2.csc
config/boards/cherryba-m1.csc
config/boards/mekotronics-r58-4x4.conf
config/boards/bananapim7.conf
config/boards/bananapim5pro.conf
config/boards/nanopim4v2.conf
config/boards/rock-3a.conf
config/boards/coolpi-genbook.csc
config/boards/longanpi-3h.csc
config/boards/khadas-edge2.conf
config/boards/lubancat2.csc
config/boards/orangepi5-max.csc
config/boards/nanopi-r3s.csc
config/boards/rock-5b.conf
config/boards/orangepi5.conf
config/boards/youyeetoo-r1-v3.csc

📚 Learning: 2025-09-12T21:44:09.061Z

Learnt from: Grippy98
Repo: armbian/build PR: 8624
File: config/boards/sk-am62p.conf:8-8
Timestamp: 2025-09-12T21:44:09.061Z
Learning: For TI K3 family boards in Armbian, BOOT_FDT_FILE uses .dts extension (not .dtb) as the standard convention. The build system handles this correctly by automatically compiling .dts to .dtb during kernel build and using the BOOT_FDT_FILE value directly in bootloader configurations.

Applied to files:

config/boards/tinkerboard-2.csc
config/boards/mekotronics-r58-4x4.conf
config/boards/bananapim7.conf
config/boards/cainiao-cniot-core.csc
config/boards/youyeetoo-r1-v3.csc

📚 Learning: 2025-03-31T22:20:41.849Z

Learnt from: rpardini
Repo: armbian/build PR: 8044
File: patch/u-boot/v2025.04/cmd-fileenv-read-string-from-file-into-env.patch:73-75
Timestamp: 2025-03-31T22:20:41.849Z
Learning: When porting patches between U-Boot versions (like from 2025.01 to 2025.04), rpardini prefers to maintain patches as-is rather than introducing refactoring changes, even when potential improvements are identified. This approach prioritizes consistency and reduces the risk of introducing new issues.

Applied to files:

config/boards/tinkerboard-2.csc
config/boards/lckfb-taishanpi.csc
config/boards/mksklipad50.conf
config/boards/mekotronics-r58-4x4.conf
config/boards/bigtreetech-cb2.conf
config/boards/cainiao-cniot-core.csc
config/boards/cm3588-nas.csc
config/boards/quartz64a.csc
config/boards/odroidm1.conf
config/boards/coolpi-genbook.csc
config/boards/9tripod-x3568-v4.csc
config/boards/station-m1.csc
config/boards/lubancat2.csc
config/boards/nanopi-r6s.conf
config/boards/quartz64b.csc
config/boards/nanopi-r3s.csc
config/boards/rock-5b.conf
config/boards/odroidm1s.csc
config/boards/rock-5b-plus.conf
config/boards/nanopct6.conf
config/boards/youyeetoo-r1-v3.csc
config/boards/mixtile-blade3.csc

📚 Learning: 2025-08-30T04:13:16.457Z

Learnt from: tabrisnet
Repo: armbian/build PR: 0
File: :0-0
Timestamp: 2025-08-30T04:13:16.457Z
Learning: Armbian kernel configuration files like linux-filogic-current.config are autogenerated overlays on top of arch defconfig. Comments added manually will be lost during future updates by maintainers, and explicit "CONFIG_OPTION is not set" statements aren't needed for mutually exclusive options since these are overlay configs that only specify changes from the base configuration.

Applied to files:

config/boards/nanopi-r3s-lts.conf
config/boards/cherryba-m1.csc
config/boards/mksklipad50.conf
config/boards/nanopim4v2.conf
config/boards/rock-3a.conf
config/boards/odroidm1.conf
config/boards/khadas-edge2.conf
config/boards/orangepi5-max.csc
config/boards/nanopi-m6.conf
config/boards/rock-5b.conf
config/boards/orangepi5.conf
config/boards/rock-5b-plus.conf
config/boards/nanopct6.conf
config/boards/orangepi5-plus.conf

📚 Learning: 2025-10-05T19:31:16.930Z

Learnt from: rpardini
Repo: armbian/build PR: 8718
File: config/boards/thinkpad-x13s.conf:185-185
Timestamp: 2025-10-05T19:31:16.930Z
Learning: In config/boards/thinkpad-x13s.conf, the x13s_obtain_firmware() function is reference-only utility code that never runs. It is kept for documentation purposes. Updates to firmware must be done at the armbian/firmware repository. TODO comments in this function are intentional reminders and should not be flagged.

Applied to files:

config/boards/nanopi-r3s-lts.conf
config/boards/mksklipad50.conf
config/boards/coolpi-genbook.csc
config/boards/nanopi-r6s.conf
config/boards/youyeetoo-r1-v3.csc

📚 Learning: 2025-09-25T18:37:00.330Z

Learnt from: tabrisnet
Repo: armbian/build PR: 8661
File: lib/functions/compilation/armbian-kernel.sh:194-199
Timestamp: 2025-09-25T18:37:00.330Z
Learning: In PR armbian/build#8661, line 235 of lib/functions/compilation/armbian-kernel.sh already contains the corrected comment "BPF link support for netfilter hooks" for NETFILTER_BPF_LINK, not the misleading "BPF_SYSCALL" comment that was flagged during review.

Applied to files:

config/boards/nanopi-r3s-lts.conf
config/boards/cainiao-cniot-core.csc
config/boards/cm3588-nas.csc
config/boards/coolpi-genbook.csc
config/boards/lubancat2.csc
config/boards/nanopct6.conf
config/boards/orangepi3b.csc

📚 Learning: 2025-06-25T03:42:09.086Z

Learnt from: EvilOlaf
Repo: armbian/build PR: 8330
File: config/sources/families/sun55iw3.conf:32-36
Timestamp: 2025-06-25T03:42:09.086Z
Learning: In Armbian build system configuration files like config/sources/families/*.conf, KERNELSOURCE is explicitly declared when using unofficial or 3rd party kernel repositories (like the "dev" branch using https://github.com/apritzel/linux), but can be omitted when using the standard mainline kernel (like the "edge" branch) since it will fall back to the default mainline source.

Applied to files:

config/boards/nanopi-r3s-lts.conf
config/boards/bananapim7.conf
config/boards/bananapim5pro.conf
config/boards/nanopim4v2.conf
config/boards/quartz64a.csc
config/boards/coolpi-genbook.csc
config/boards/9tripod-x3568-v4.csc
config/boards/khadas-edge2.conf
config/boards/station-m1.csc
config/boards/lubancat2.csc
config/boards/quartz64b.csc
config/boards/nanopi-r3s.csc
config/boards/mixtile-edge2.csc
config/boards/orangepi3b.csc

📚 Learning: 2025-06-25T03:40:52.109Z

Learnt from: EvilOlaf
Repo: armbian/build PR: 8330
File: config/sources/families/sun55iw3.conf:32-36
Timestamp: 2025-06-25T03:40:52.109Z
Learning: In Armbian build system configuration files like config/sources/families/*.conf, when KERNELSOURCE is not explicitly declared in a case branch, the system falls back to a default KERNELSOURCE value, so missing KERNELSOURCE declarations are not critical issues.

Applied to files:

config/boards/nanopi-r3s-lts.conf
config/boards/bananapim5pro.conf
config/boards/nanopi-r3s.csc
config/boards/orangepi5.conf

📚 Learning: 2025-11-10T23:44:53.363Z

Learnt from: tabrisnet
Repo: armbian/build PR: 0
File: :0-0
Timestamp: 2025-11-10T23:44:53.363Z
Learning: For the RV1106 family in Armbian (config/sources/families/rockchip-rv1106.conf), udev.children-max=1 is set in the kernel boot parameters to prevent early-boot OOM errors. The RV1106 has a single-core CPU, so parallelism in udev child processes provides no practical benefit. Testing higher values is impractical due to the difficulty of monitoring at this early boot stage.

Applied to files:

config/boards/nanopi-r3s-lts.conf
config/boards/nanopim4v2.conf
config/boards/nanopi-r6s.conf
config/boards/youyeetoo-r1-v3.csc

📚 Learning: 2025-09-11T06:16:10.236Z

Learnt from: SuperKali
Repo: armbian/build PR: 8609
File: config/boards/nanopi-r76s.conf:5-5
Timestamp: 2025-09-11T06:16:10.236Z
Learning: In Armbian board configuration files, WIP (Work In Progress) comments describe intended goals or planned features rather than current implementation state. For example, a comment like "WIP: current kernel" indicates that current kernel support is being worked toward, even if KERNEL_TARGET doesn't yet include "current".

Applied to files:

config/boards/cherryba-m1.csc
config/boards/nanopim4v2.conf

📚 Learning: 2025-08-21T08:10:25.459Z

Learnt from: leggewie
Repo: armbian/build PR: 8524
File: config/boards/nanopiduo2.csc:12-12
Timestamp: 2025-08-21T08:10:25.459Z
Learning: KERNEL_TARGET and KERNEL_TEST_TARGET in Armbian build system do not have enforced validation relationships. KERNEL_TARGET is used for interactive menu ordering and branch validation, while KERNEL_TEST_TARGET is used for build list generation and recorded in /etc/armbian-release. No existing codebase validation enforces that KERNEL_TEST_TARGET values must be present in KERNEL_TARGET.

Applied to files:

config/boards/cherryba-m1.csc

📚 Learning: 2025-08-21T08:10:59.502Z

Learnt from: leggewie
Repo: armbian/build PR: 8524
File: config/boards/orangepi2.csc:6-6
Timestamp: 2025-08-21T08:10:59.502Z
Learning: Not all Armbian boards support all kernel versions (legacy, current, edge). Some boards may only support specific kernel versions due to hardware limitations or lack of mainline support, which is why their KERNEL_TARGET contains only the supported options (e.g., just "legacy").

Applied to files:

config/boards/cherryba-m1.csc

📚 Learning: 2025-06-12T21:08:11.318Z

Learnt from: djurny
Repo: armbian/build PR: 8287
File: config/bootscripts/boot-sunxi.cmd:13-23
Timestamp: 2025-06-12T21:08:11.318Z
Learning: In config/bootscripts/boot-sunxi.cmd the variable name `align_overlap_oboe_avoidance` intentionally uses the acronym “OBOE” (Off-By-One Error); it is not a typo and should not be renamed.

Applied to files:

config/boards/lckfb-taishanpi.csc
config/boards/odroidm1.conf
config/boards/longanpi-3h.csc
config/boards/9tripod-x3568-v4.csc

📚 Learning: 2025-09-14T11:37:35.089Z

Learnt from: amazingfate
Repo: armbian/build PR: 8619
File: config/sources/families/rockchip.conf:65-72
Timestamp: 2025-09-14T11:37:35.089Z
Learning: In the Armbian build system, patch directories referenced in BOOTPATCHDIR and KERNELPATCHDIR configurations can be non-existent without causing build failures. Empty patch directories are also ignored by git, so missing patch directories should not be flagged as errors during code review.

Applied to files:

config/boards/lckfb-taishanpi.csc
config/boards/mksklipad50.conf
config/boards/cainiao-cniot-core.csc
config/boards/odroidm1.conf
config/boards/longanpi-3h.csc

📚 Learning: 2025-06-04T23:45:38.860Z

Learnt from: djurny
Repo: armbian/build PR: 8272
File: config/bootscripts/boot-mvebu.cmd:182-186
Timestamp: 2025-06-04T23:45:38.860Z
Learning: In config/bootscripts/boot-mvebu.cmd, the `fdtfile` variable is mandatory for booting and is pre-set by U-Boot, but can be overridden via armbianEnv.txt. If `fdtfile` is empty, the subsequent device tree file search logic will eventually fail and trigger the critical error "Cannot find DT!" with proper error handling.

Applied to files:

config/boards/mksklipad50.conf
config/boards/mekotronics-r58-4x4.conf
config/boards/bigtreetech-cb2.conf
config/boards/odroidm1.conf
config/boards/orangepi5-max.csc
config/boards/rock-5b-plus.conf
config/boards/nanopct6.conf
config/boards/youyeetoo-r1-v3.csc
config/boards/mixtile-blade3.csc

📚 Learning: 2025-06-12T21:03:39.686Z

Learnt from: djurny
Repo: armbian/build PR: 8287
File: config/bootscripts/boot-sunxi.cmd:148-161
Timestamp: 2025-06-12T21:03:39.686Z
Learning: In Armbian U-Boot bootscripts, the `${cpu}` environment variable is always pre-set by U-Boot (or defaults to a valid value), so additional guards against it being unset are unnecessary.

Applied to files:

config/boards/mksklipad50.conf
config/boards/bigtreetech-cb2.conf
config/boards/longanpi-3h.csc
config/boards/9tripod-x3568-v4.csc
config/boards/quartz64b.csc
config/boards/nanopct6.conf
config/boards/youyeetoo-r1-v3.csc
config/boards/mixtile-blade3.csc

📚 Learning: 2025-05-07T20:49:40.969Z

Learnt from: djurny
Repo: armbian/build PR: 8166
File: config/bootscripts/boot-mvebu.cmd:38-50
Timestamp: 2025-05-07T20:49:40.969Z
Learning: The 4KB (0x1000) boundary used for device tree size calculations in U-Boot scripts is specific to how the `fdt resize` command works internally and should remain hardcoded rather than being tied to adjustable alignment variables.

Applied to files:

config/boards/mekotronics-r58-4x4.conf

📚 Learning: 2025-11-08T06:39:24.527Z

Learnt from: EvilOlaf
Repo: armbian/build PR: 8886
File: patch/kernel/rk35xx-vendor-6.1/dt/rk3528-nanopi-rev01.dts:9-9
Timestamp: 2025-11-08T06:39:24.527Z
Learning: In Armbian's Rockchip vendor kernel branches (rk35xx-vendor), device tree files may not require the same headers as mainline Linux. For example, input key definitions like KEY_BACK and KEY_VOLUMEUP may be handled differently in BSP kernels and don't necessarily need explicit includes like <dt-bindings/input/input.h> that would be required in mainline kernel device trees.

Applied to files:

config/boards/mekotronics-r58-4x4.conf
config/boards/bananapim7.conf
config/boards/bananapim5pro.conf
config/boards/rock-3a.conf

📚 Learning: 2025-09-14T05:23:42.991Z

Learnt from: EvilOlaf
Repo: armbian/build PR: 8632
File: config/sources/families/include/rockchip64_common.inc:327-334
Timestamp: 2025-09-14T05:23:42.991Z
Learning: In the Armbian build system for Rockchip boards, SPI flash consistently maps to /dev/mtd0, so hard-coding this device path in flashcp commands is acceptable and based on hardware conventions rather than being a bug.

Applied to files:

config/boards/bigtreetech-cb2.conf

📚 Learning: 2025-05-05T12:35:07.143Z

Learnt from: Grippy98
Repo: armbian/build PR: 8152
File: lib/functions/configuration/interactive.sh:209-266
Timestamp: 2025-05-05T12:35:07.143Z
Learning: For the interactive kernel selection in Armbian, KERNEL_MAJOR_MINOR and KERNEL_DESCRIPTION are parsed from family.conf but deliberately not set as environment variables to avoid potential interference with other parts of the build system.

Applied to files:

config/boards/bananapim5pro.conf

📚 Learning: 2025-09-14T06:10:25.610Z

Learnt from: EvilOlaf
Repo: armbian/build PR: 8619
File: config/sources/families/rockchip.conf:64-70
Timestamp: 2025-09-14T06:10:25.610Z
Learning: In the Armbian build system, rk32xx and rk33xx Rockchip SoCs no longer have BSP-based (vendor) kernel branches. The rk3506 is the first 32-bit Rockchip SoC to use the vendor branch in the current codebase.

Applied to files:

config/boards/nanopim4v2.conf

📚 Learning: 2025-09-22T22:08:54.273Z

Learnt from: tabrisnet
Repo: armbian/build PR: 0
File: :0-0
Timestamp: 2025-09-22T22:08:54.273Z
Learning: When extracting comments from Linux Kconfig files, def_bool and def_tristate entries use their parameter as a dependency/default condition, not as a feature description. Comments should be generated differently for these entry types to avoid misleading inline documentation.

Applied to files:

config/boards/quartz64a.csc

📚 Learning: 2025-11-11T20:56:20.280Z

Learnt from: glneo
Repo: armbian/build PR: 8913
File: config/sources/families/include/k3_common.inc:57-60
Timestamp: 2025-11-11T20:56:20.280Z
Learning: In config/sources/families/include/k3_common.inc, the OP-TEE build command at line 59 should be updated in a future PR to explicitly set CROSS_COMPILE64=aarch64-linux-gnu- and CROSS_COMPILE32=arm-linux-gnueabihf- instead of relying on OP-TEE's internal defaults, for better clarity and maintainability. User glneo agreed to address this in a separate PR.

Applied to files:

config/boards/coolpi-genbook.csc

📚 Learning: 2025-07-25T03:51:50.830Z

Learnt from: EvilOlaf
Repo: armbian/build PR: 8428
File: config/boards/lckfb-taishanpi.csc:5-9
Timestamp: 2025-07-25T03:51:50.830Z
Learning: When reviewing PRs in the Armbian build system, U-Boot defconfig files and patches may be added as part of the PR changes but might not be visible in the current repository clone state during review. It's important to check the actual PR file changes directly via GitHub or the PR API to get the complete picture of what files are being added or modified.

Applied to files:

config/boards/coolpi-genbook.csc
config/boards/orangepi5-max.csc
config/boards/nanopi-m6.conf
config/boards/orangepi5.conf
config/boards/odroidm1s.csc
config/boards/nanopct6.conf
config/boards/youyeetoo-r1-v3.csc
config/boards/orangepi5-plus.conf

📚 Learning: 2025-09-27T21:50:15.915Z

Learnt from: tabrisnet
Repo: armbian/build PR: 8678
File: config/kernel/linux-sunxi64-current.config:94-94
Timestamp: 2025-09-27T21:50:15.915Z
Learning: When kernel config files are generated through Armbian's automated process (previous config → armbian-kernel.sh changes → make oldconfig → Armbian machinery processing), manual config file edits are not appropriate since they would be overwritten. Deprecated option handling should be implemented in the automated tooling instead.

Applied to files:

config/boards/khadas-edge2.conf
config/boards/nanopi-m6.conf
config/boards/youyeetoo-r1-v3.csc

📚 Learning: 2025-10-03T11:42:46.660Z

Learnt from: igorpecovnik
Repo: armbian/build PR: 8705
File: .github/workflows/rewrite-kernel-configs.yml:96-169
Timestamp: 2025-10-03T11:42:46.660Z
Learning: In the Armbian build repository's kernel config rewrite workflow (.github/workflows/rewrite-kernel-configs.yml), deletion of kernel config files does not need to be handled. The workflow intentionally only captures ACMR (added/copied/modified/renamed) changes and does not need to propagate deletions to the aggregator.

Applied to files:

config/boards/khadas-edge2.conf

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

SuperKali

It seems okay, I haven't tested it but it should work as before.

github-actions · 2025-11-13T07:12:35Z

✅ This PR has been reviewed and approved — all set for merge!

* live_main_upstream/main: (227 commits) rockchip64: rewrite patches rockchip64: remove upstreamed fixes Change mainline to rc7, manually fix meson64 patch `Automatic` board configs status synchronise KERNEL_TEST_TARGET is just override. We won't both targets, so we have both. rk3576: nanopi-r76s: add mainline u-boot and fix USB3.0 host (armbian#8997) Rock-5B-Plus: Use upstream device-tree name Radxa E54c: change board support status `Automatic` board configs status synchronise `Automatic` board configs status synchronise build(deps): bump tj-actions/changed-files bananapi-r4 bpi-r4 board config - no video output build(deps): bump actions/checkout from 5 to 6 Radxa Rock 2A and F: promote boards to standard support config: drop questing and resolute symlinks for package definitions Drop Thunderbolt in desktop packages, but enable in minimal, arch amd64 only Update radxa-e52c.conf boards / Helios4: reorder some lines in the config file boards / Helios4: Fix: libfdt fdt_path_offset() returned FDT_ERR_NOTFOUND boards / Helios4: fix 0002 patch after bump U-Boot v2025.10 boards / Helios4: rebase previous u-boot patchset to v2025.10 boards / Helios4: reenable Armbian patchset boards / Helios4: drop obsolete patches and those not applicable to helios4 boards / Helios4: rename some patches in preparation for rebase boards / Helios4: enable SATA u-boot artifact boards / Helios4: switch U-Boot to mainline 2025.10 radxa-rock-4d: Move to standard support (armbian#8981) Sync support status to match with /download Rock5B+: Udev rule for Radxa Display 8HD sunxi64: Enable KVM virtualization support for current kernel Discord x86: add external sources `Automatic` board configs status synchronise rock-5b: u-boot: edge: bump to v2026.01-rc2; use mainline ATF; bootorder; fancy u-boot Desktop (mainly Gnome ) - add additional packages, small fixes and improvements lib / main-config.sh: enable APA extension for questing and resolute builds. Closes: armbian#8966 ti: configs: boards: Add BOOT_SOC variable ti: configs: boards: Add AM62L EVM (tmds62levm) board support Rock5B-Plus and Rock5T: Use upstream u-boot (armbian#8918) youyeetoo-r1: enable OUT1/OUT2 switches for es8323 headphone output on vendor kernel (armbian#8963) Fixing updating submodule Powere management - make it conditional, enable on UEFI targets, else disabled `Automatic` board configs status synchronise uefi: x86: current (6.12) and edge (6.18): add Apple T2 patches Add watchdog package into image, hardware watchdog works Allow Helios64 to do separate /boot partition only if root placed on fs than unbootable for device u-boot: prepare v2026.01 patch directory Move gxlimg to board level and some clean rockchip: cleanup and rewrite patches for `edge` rockchip: cleanup and rewrite patches for `current` nanopct6(-lts): u-boot: bump to v2026.01-rc2 odroidhc4: u-boot: bump to v2026.01-rc2 cm3588-nas: u-boot: bump to v2026.01-rc2, enable BTRFS support cm3588-nas: u-boot: fix `led-1` to `green` for preboot blinking khadas-vim3l: u-boot: bump to v2026.01-rc2, enable BTRFS and more nanopi-r6c: u-boot: bump to v2026.01-rc2; enable BTRFS support uefi-loong64-6.18: rewrite patches against v6.18-rc6, no changes mainline-kernel: bump 6.18 to v6.18-rc6 jsoninfo: introduce `inventory-artifacts` cli artifact-kernel: include LINUXCONFIG and ARMBIAN_KERNEL_DEB_NAME in artifact_input_variables config/templates: introduce targets-all-kernels.yaml for optimized kernel inventory-ing Upgrade Allwinner CURRENT kernels to latest Generic bootscript template Enable bootscript templating `Automatic` board configs status synchronise BeagleBoard and Description Updates ti: configs: family: k3: Update vendor-edge to pull latest TI PSDK tag ti: configs: family: k3: Update to bootable Processor SDK release tag ti: configs: family: k3: Add upstream edge branch ti: configs: family: k3: Change current/edge to vendor/vendor-edge sm8250 current: Add support to load QUP SE Firmware via Linux subsystem `Automatic` board configs status synchronise extensions: gxlimg: Update repo URL nanopi-m6: drop vendor uboot nanopi-r6s: remove old legacy uboot files && update mainline uboot sm8250 current: Select all USB CAN adapters under the CAN USB interfaces menu as M sm8250 current: Select all USB network adapters under the USB_NET_DRIVERS menu as M tools: Bump `BATCAT_VERSION` from 0.25.0 to 0.26.0 `Automatic` board configs status synchronise Add Ubuntu 25.10 / 26.04 questing and resolute as csc build target, demote Bookworm to csc Related to armbian/documentation#842, update extensions/gen-sample-extension-docs.sh to reference the opt-out docs for hooks rockchip: rk3576: Fix serial console to use UART0 (ttyS0) (armbian#8936) Drop patches that has been upstreamed - rockchip and sm8550 orangepi5: drop vendor uboot MOTD: deterministic spacing, tidy and compact output Bugfix: quotes were downloading to wrong location maint: cleanup board config files (armbian#8929) Use next patch version when using main action script Helios64: workaround fancontrol /dev restriction vs Helios64 udev /dev symlinks Add type of bootable fs for ODroid-N2 Preserve timestamps when copying log files Rockchip64: enable Qcom ath12 (wifi 7) support UFS: Fix CI behavior (armbian#8924) UFS: Fix ci config generation (armbian#8923) First login: create docker group and add normal user to it (armbian#8920) Framework: copy user provided first boot config at build time `Automatic` board configs status synchronise k3-beagle: Add config for BeagleBoard.org Linux and U-Boot k3: Factor out all K3 common configuration into k3_common.inc k3: Use CORESDK_TAG for setting ATFBRANCH beagley-ai: Switch current branch to 6.12 Beagle kernel ... Signed-off-by: Jonas Wood <[email protected]>

EvilOlaf added 9 commits November 13, 2025 04:51

cleanup comments, linebreaks...

594b206

two more comments

b472588

BOOTFS_TYPE has never been set as far as I can see, therefore no ne…

a5434a5

…ed to unset.

some more comments...

3b823c0

comment, simplify logic

3f20ff1

even more comments

bd184ef

just a few more

f40498f

comments, description for elish

a77bd6f

merge uboot functions. @SuperKali review

247777d

EvilOlaf requested review from ColorfulRhino, HeyMeco, JohnTheCoolingFan, SuperKali, Tonymac32, adeepn, amazingfate, brentr, catalinii, efectn, igorpecovnik, pyavitz and rpardini as code owners November 13, 2025 05:29

github-actions bot added size/medium PR with more then 50 and less then 250 lines 11 Milestone: Fourth quarter release Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... labels Nov 13, 2025

SuperKali approved these changes Nov 13, 2025

View reviewed changes

github-actions bot added the Ready to merge Reviewed, tested and ready for merge label Nov 13, 2025

github-actions bot removed the Needs review Seeking for review label Nov 13, 2025

igorpecovnik approved these changes Nov 13, 2025

View reviewed changes

igorpecovnik merged commit 05303e8 into armbian:main Nov 13, 2025
1 check passed

EvilOlaf deleted the cleanup branch December 4, 2025 04:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

maint: cleanup board config files #8929

maint: cleanup board config files #8929

EvilOlaf commented Nov 13, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Nov 13, 2025 •

edited

Loading

Uh oh!

SuperKali left a comment

Uh oh!

github-actions bot commented Nov 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Uh oh!

maint: cleanup board config files #8929

maint: cleanup board config files #8929

Conversation

EvilOlaf commented Nov 13, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Checklist:

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

SuperKali left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

EvilOlaf commented Nov 13, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 13, 2025 •

edited

Loading