WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Nov 15, 2025

Description

Maintenance - dropping upstreamed patches.

How Has This Been Tested?

  • CI compilation

Checklist:

  • My changes generate no new warnings

Summary by CodeRabbit

  • Chores
    • Disabled Verisilicon media kernel patch in rockchip configuration
    • Removed SDR50 tuning support from storage driver in SM8550 kernel

@igorpecovnik igorpecovnik added Work in progress Unfinished / work in progress Build Executing build train (permission needed) labels Nov 15, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 15, 2025

Walkthrough

Patch series modifications across rockchip-6.17 and sm8550-6.12 kernel archives. Two rockchip-6.17 patch configuration files disable the Verisilicon media patch entry, while SDR50 tuning logic is removed from an sdhci-msm driver patch in the sm8550-6.12 series.

Changes

Cohort / File(s) Change Summary
Rockchip-6.17 Verisilicon patch disable
patch/kernel/archive/rockchip-6.17/libreelec.series, patch/kernel/archive/rockchip-6.17/series.conf
Commented out the 0065 Verisilicon media patch entry in both patch series configuration files, effectively disabling its application
SM8550-6.12 SDR50 tuning removal
patch/kernel/archive/sm8550-6.12/0042_mmc--sdhci-msm--Enable-tuning-for-SDR50-mode-for-S.patch
Removed SDR50-tuning support additions including CORE_HC_SELECT_IN_SDR50 macro, early return logic in sdhci_msm_is_tuning_needed, and SDR50-specific tuning block in sdhci_msm_execute_tuning

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Straightforward patch series modifications with clear intent (disabling/removing specific patches)
  • Requires verification that commenting out the Verisilicon patch doesn't break rockchip-6.17 builds
  • Confirm that SDR50 tuning removal doesn't negatively impact sm8550-6.12 SD card performance

Possibly related PRs

  • PR #8703: Replaces and rebases LibreELEC patches for rockchip64 6.17 kernel, directly related to the Verisilicon patch series modifications
  • PR #8649: Rockchip-6.17 LibreELEC patch reorganization work that coordinates with the patch disable changes

Suggested labels

size/medium

Suggested reviewers

  • paolosabatino
  • rpardini
  • amazingfate
  • igorpecovnik
  • krachlatte
  • joekhoobyar

Poem

🐰 A patch here, a config there,
We hop through the kernel with care,
Verisilicon takes a rest,
SDR50 leaves the nest,
Patch management done with flair! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Drop patches that has been upstreamed - rockchip and sm8550' directly matches the changes: patches are being disabled/removed for both rockchip-6.17 and sm8550-6.12 as they have been upstreamed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch droppatches

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • AR-9999: Request failed with status code 404

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... 11 Milestone: Fourth quarter release size/medium PR with more then 50 and less then 250 lines labels Nov 15, 2025
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Work in progress Unfinished / work in progress Build Executing build train (permission needed) Needs review Seeking for review labels Nov 15, 2025
@igorpecovnik igorpecovnik merged commit 9b5518d into main Nov 15, 2025
522 of 527 checks passed
@igorpecovnik igorpecovnik deleted the droppatches branch November 15, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

11 Milestone: Fourth quarter release Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/medium PR with more then 50 and less then 250 lines

Development

Successfully merging this pull request may close these issues.

2 participants