Improve Desktop AppGroups & Add Default User Icon #8964
Conversation
WalkthroughUpdates several desktop appgroup package lists (chat, desktop_tools, multimedia, office, GNOME base, AMD64 chat) to add/remove package entries, and modifies the armbian-firstlogin script to add a new set_user_icon() helper and make docker group creation quieter. Changes
Sequence Diagram(s)sequenceDiagram
participant FL as armbian-firstlogin
participant FS as Filesystem
participant AS as AccountsService
rect rgba(135,206,235,0.12)
Note over FL: user creation flow (updated)
FL->>FL: validate username
FL->>FL: create user & groups (addgroup --system docker --quiet)
FL->>FS: copy default icon -> /var/lib/AccountsService/icons/<user>
FS-->>FL: confirm write
FL->>AS: write /var/lib/AccountsService/users/<user> metadata
AS-->>FL: persist metadata
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Suggested labels
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Disabled knowledge base sources:
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (6)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
11
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
packages/bsp/common/usr/share/armbian/armbian-user-icon.pngis excluded by!**/*.png
📒 Files selected for processing (7)
config/desktop/common/appgroups/chat/packages(0 hunks)config/desktop/common/appgroups/desktop_tools/packages(1 hunks)config/desktop/common/appgroups/multimedia/packages(1 hunks)config/desktop/common/appgroups/office/packages(1 hunks)config/desktop/common/environments/gnome/config_base/packages(1 hunks)config/optional/architectures/amd64/_config/desktop/common/appgroups/chat/packages(1 hunks)packages/bsp/common/usr/lib/armbian/armbian-firstlogin(3 hunks)
💤 Files with no reviewable changes (1)
- config/desktop/common/appgroups/chat/packages
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: welcome-first-time-contributor
🔇 Additional comments (8)
config/desktop/common/appgroups/office/packages (1)
1-2: LGTM! Office package additions are appropriate.The additions of Evince (document viewer) and sane-utils (scanner support) appropriately expand office functionality for desktop environments.
Also applies to: 7-7
config/desktop/common/appgroups/desktop_tools/packages (1)
2-2: LGTM! Baobab is a useful desktop tool addition.Baobab (GNOME disk usage analyzer) is a standard utility that fits well in the desktop tools group.
config/desktop/common/appgroups/multimedia/packages (1)
5-7: LGTM! Multimedia package additions enhance GNOME desktop experience.The additions of Shotwell (photo manager), Rhythmbox (music player), and Totem (video player) are standard GNOME multimedia applications that appropriately expand the multimedia appgroup.
Also applies to: 9-9
config/optional/architectures/amd64/_config/desktop/common/appgroups/chat/packages (1)
1-1: LGTM! AMD64-specific Discord package addition is appropriate.Adding Discord as an AMD64-specific chat application aligns with the PR objectives and makes sense given Discord's architecture limitations.
config/desktop/common/environments/gnome/config_base/packages (2)
5-11: LGTM! Printing and hardware integration packages enhance GNOME functionality.The additions of CUPS components, Bluetooth support (bluez-cups), Thunderbolt support (bolt), fingerprint support (fprintd), and CIFS utilities appropriately expand hardware and printing integration for GNOME desktop environments.
18-23: LGTM! Font additions improve internationalization support.The additional Noto, Arphic, Droid, and Liberation fonts enhance multilingual and CJK language support for GNOME desktop environments.
packages/bsp/common/usr/lib/armbian/armbian-firstlogin (2)
611-611: LGTM! Docker group creation improvement.Adding the
--quietflag appropriately suppresses normal output while preserving error handling on line 612.
643-665: I'll search for AccountsService documentation to verify the metadata timing concern.No verification issues found; the code pattern is valid.
AccountsService is used to manage user configuration, and metadata files in
/var/lib/AccountsService/users/are a standard approach for configuring user properties. Theset_user_icon()function correctly pre-creates the metadata file before the user account is added to/etc/passwdat line 589. When AccountsService loads users, it will recognize and apply metadata from existing files, so the icon metadata will be available when the user account is subsequently created.
igorpecovnik
force-pushed
the
desktop-improve
branch
2 times, most recently
from
421c46f to
521b222
Compare
igorpecovnik
force-pushed
the
desktop-improve
branch
from
521b222 to
9926c55
Compare
igorpecovnik
added
Ready to merge
Summary
This update enhances the Armbian GNOME desktop experience by expanding application groups, improving hardware/printing integration, and assigning a branded default user icon during first login.
Changes
AppGroups
discordfor amd64baobabshotwell,rhythmbox,rhythmbox-data,totemevince,evince-common,sane-utilsGNOME environment
cups-browsed, cups-bsd, cups-pk-helper, bluez-cups,bolt, cifs-utils, fprintd,additional fonts (
noto, arphic, droid, liberation-narrow)First Login
Add
set_user_icon()to automatically assign the default Armbian user avatarMisc
Quiet docker group creation
How Has This Been Tested?
Checklist:
Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.