WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@leggewie
Copy link
Collaborator

@leggewie leggewie commented Nov 24, 2025

Summary by CodeRabbit

  • Chores
    • Cleaned up configuration files by removing outdated entries from CLI and desktop settings.

✏️ Tip: You can customize this high-level summary in your review settings.

- this is handled by APA now
- this is another step to fix armbian#8965
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 24, 2025

Walkthrough

Removes "noble" configuration references from four build configuration files: config/cli/questing, config/cli/resolute, config/desktop/questing, and config/desktop/resolute. This addresses issues where the questing distribution was incorrectly linked to Ubuntu's noble release, causing package conflicts.

Changes

Cohort / File(s) Change Summary
Configuration String Removals
config/cli/questing, config/cli/resolute, config/desktop/questing, config/desktop/resolute
Removed "noble" string references from configuration files

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Simple deletion of configuration strings across four related files with no logic or dependencies affected

Possibly related PRs

Suggested reviewers

  • igorpecovnik
  • EvilOlaf

Poem

A rabbit hops through configs bright,
Removing noble from the sight,
Now questing's closer to its kin,
With packages aligned within,
Build errors fade—hooray, hooray! 🐰✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'config: drop questing and resolute symlinks for package definitions' accurately summarizes the main change: removal of configuration entries for questing and resolute from multiple config files.
Linked Issues check ✅ Passed The PR removes the 'noble' package definition references from questing and resolute configurations, directly addressing issue #8965's root cause of bad packages in questing desktop builds.
Out of Scope Changes check ✅ Passed All changes are in-scope: the PR only removes configuration file entries for questing and resolute from CLI and desktop config directories, with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8a13522 and af9abf4.

📒 Files selected for processing (4)
  • config/cli/questing (0 hunks)
  • config/cli/resolute (0 hunks)
  • config/desktop/questing (0 hunks)
  • config/desktop/resolute (0 hunks)
💤 Files with no reviewable changes (4)
  • config/cli/questing
  • config/desktop/questing
  • config/desktop/resolute
  • config/cli/resolute

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size/small PR with less then 50 lines 11 Milestone: Fourth quarter release Desktop Graphical user interface Needs review Seeking for review Framework Framework components labels Nov 24, 2025
@github-actions github-actions bot added the Ready to merge Reviewed, tested and ready for merge label Nov 24, 2025
@github-actions
Copy link
Contributor

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions bot removed the Needs review Seeking for review label Nov 24, 2025
@igorpecovnik igorpecovnik merged commit dd898c7 into armbian:main Nov 24, 2025
11 checks passed
@igorpecovnik
Copy link
Member

igorpecovnik commented Nov 25, 2025

Since no packages are defined for deboostrap process, this fails elsewhere:
#8996

[Libera] the --include parameter is empty for both
[Libera] '--include=${AGGREGATED_PACKAGES_DEBOOTSTRAP_COMMA}' so aggregation.py is giving us nothing.

@tabrisnet @pyavitz

When dropping this, it start to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

11 Milestone: Fourth quarter release Desktop Graphical user interface Framework Framework components Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

[Bug]: Bad packages in questing desktop build

2 participants