WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@tabrisnet
Copy link
Collaborator

@tabrisnet tabrisnet commented Dec 5, 2025

Description

requested feature #9021
Explicitly exclude filogic, not so much because it's necessary but because it also serves as an example for armbian/documentation#842

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • time ./compile.sh rewrite-kernel-config BOARD=pocketbeagle2 BRANCH=edge KERNEL_GIT=full MANAGE_ACNG='http://squid.tabris.net:3142/'
  • time ./compile.sh rewrite-kernel-config BOARD=bananapir4 BRANCH=current KERNEL_GIT=full MANAGE_ACNG='http://squid.tabris.net:3142/'
  • time ./compile.sh rewrite-kernel-config BOARD=bananapir4 BRANCH=edge KERNEL_GIT=full MANAGE_ACNG='http://squid.tabris.net:3142/'

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@tabrisnet tabrisnet requested review from a team and igorpecovnik as code owners December 5, 2025 17:17
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 5, 2025

Walkthrough

Adds a new kernel configuration function to enable NTSYNC (Windows NT synchronization primitives) for kernel versions 6.14 and above, while disabling this feature for the filogic platform family through configuration override.

Changes

Cohort / File(s) Summary
Kernel NTSYNC Configuration
lib/functions/compilation/armbian-kernel.sh
New function armbian_kernel_config__enable_ntsync() that enables NTSYNC support for kernel >= 6.14; skips activation on vendor branches and appends to opts_m list when enabled
Filogic Family Configuration
config/sources/families/filogic.conf
Disables the ntsync kernel config function for filogic family, noting that Proton/WINE is unlikely on this platform

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Focus on verifying the NTSYNC function's version check logic (>= 6.14) and opts_m list handling
  • Confirm that unsetting the function in filogic.conf appropriately disables the feature for that platform

Suggested reviewers

  • igorpecovnik
  • chraac
  • AGM1968
  • teknoid
  • EvilOlaf

Poem

🐰 A kernel tweak for Windows sync so fine,
Where NTSYNC dances in code's design,
But filogic says "nay, we've no need for wine,"
So the function's unset in its config line—
Smart choices keep systems running divine! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'framework - enable NTSYNC as a module on most kernels' accurately reflects the main objective of enabling NTSYNC across most kernels while excluding specific cases like filogic.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size/small PR with less then 50 lines 02 Milestone: First quarter release Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Framework Framework components labels Dec 5, 2025
@github-actions github-actions bot added the Ready to merge Reviewed, tested and ready for merge label Dec 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions bot removed the Needs review Seeking for review label Dec 5, 2025
@igorpecovnik igorpecovnik merged commit f53eac4 into armbian:main Dec 5, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

02 Milestone: First quarter release Framework Framework components Hardware Hardware related like kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

2 participants