[FEATURE] Support array comparison #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fl0rian-p
commented
Dec 12, 2025
| /** | ||
| * Helper class to build a java.sql.Array without using a DB connection | ||
| */ | ||
| private static class SimpleArray implements Array { |
Contributor
Author
There was a problem hiding this comment.
@VanRoy, Not sure on the best way to go there: I found no simple native helper to create a java.sql.Array.
In this class there are two ways :
- this static class
- or getting one from a connection : connection would need to kept inside throughout the test otherwise the object would be closed upon calling
Array#getArray.
Please tell me which way you prefer and I'll update the code
Contributor
Author
There was a problem hiding this comment.
Done 👍
That should be ready for full review :)
fl0rian-p
force-pushed
the
feature/support-array-comparison
branch
2 times, most recently
from
26e85f0 to
a2e30b0
Compare
fl0rian-p
force-pushed
the
feature/support-array-comparison
branch
from
a2e30b0 to
92dc23d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to solve issue #325.
It introduces array comparison to avoid detecting changes when there are none.