WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Check other platforms #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dawsoneliasen wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Check other platforms #128

Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
5b4c1c3
add macos
dawsoneliasen Aug 16, 2020
d7bc4ed
add windows check
dawsoneliasen Aug 16, 2020
c847adf
remove -y from brew install
dawsoneliasen Aug 16, 2020
10b4693
compile numdiff from source
dawsoneliasen Aug 16, 2020
b710e08
windows comes with boost installed
dawsoneliasen Aug 16, 2020
fe61085
install doxygen on macos, spell 'latest' correctly
dawsoneliasen Aug 16, 2020
72a4b5e
setup boost on windows
dawsoneliasen Aug 17, 2020
f9c590e
oops can't use bash
dawsoneliasen Aug 17, 2020
f504875
try requiring boost 1.72
dawsoneliasen Aug 17, 2020
108c42c
try a lighter requirement for boost
dawsoneliasen Aug 17, 2020
dd2b69a
Update .github/workflows/SampleFlow-test.yml
dawsoneliasen Aug 19, 2020
4e96d1a
Update .github/workflows/SampleFlow-test.yml
dawsoneliasen Aug 19, 2020
b58b2ed
Update .github/workflows/SampleFlow-test.yml
dawsoneliasen Aug 19, 2020
3a5f322
Update .github/workflows/SampleFlow-test.yml
dawsoneliasen Aug 19, 2020
8052402
Update .github/workflows/SampleFlow-test.yml
dawsoneliasen Aug 19, 2020
1e16e11
Update .github/workflows/SampleFlow-test.yml
bangerth Aug 19, 2020
bbe31f5
Update .github/workflows/SampleFlow-test.yml
dawsoneliasen Aug 20, 2020
4c1b78b
Update .github/workflows/SampleFlow-test.yml
dawsoneliasen Aug 26, 2020
16a3ba2
Update .github/workflows/SampleFlow-test.yml
dawsoneliasen Aug 26, 2020
a123567
Update .github/workflows/SampleFlow-test.yml
dawsoneliasen Aug 26, 2020
d9c09b7
Update CMakeLists.txt
dawsoneliasen Aug 26, 2020
3c80b68
Update .github/workflows/SampleFlow-test.yml
dawsoneliasen Aug 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 36 additions & 1 deletion .github/workflows/SampleFlow-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ on:


jobs:
build:

build-linux:

runs-on: ubuntu-latest

Expand All @@ -32,3 +33,37 @@ jobs:
cd ../../..
./doc/indent
git --no-pager diff --exit-code

build-macos:

runs-on: macos-latest

steps:
- uses: actions/checkout@v2
- name: install dependencies
run: |
brew install cmake boost doxygen
git clone https://github.com/tjhei/numdiff.git
Copy link
Owner

@bangerth bangerth Aug 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the repository of my friend Timo Heister, but it's not the master repository for the numdiff project. Is that what you had in mind?

Copy link
Contributor Author

@dawsoneliasen dawsoneliasen Aug 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's weird - it's the first thing that comes up when I search for numdiff. Can you point me to the master for the numdiff project?

Copy link
Owner

@bangerth bangerth Aug 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project lives here: https://www.nongnu.org/numdiff/

You should be able to get it via wget from http://download-mirror.savannah.gnu.org/releases/numdiff/ as a .tar.gz file that you can unpack via tar xvzf file.tar.gz.

cd numdiff
./configure
make && sudo make install
cd ..
- name: cmake
run: cmake .
- name: ctest
run: ctest --output-on-failure -j2

build-windows:

runs-on: windows-latest

steps:
- uses: actions/checkout@v2
- name: setup-boost
run: |
$Env:BOOST_ROOT = $env:BOOST_ROOT_1_72_0
$Env:Boost_INCLUDE_DIR = "$env:BOOST_ROOT\include"
- name: cmake
run: cmake .
- name: ctest
run: ctest --output-on-failure -j2
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ INCLUDE_DIRECTORIES(include ${CMAKE_BINARY_DIR}/include)

# Set paths correctly to take BOOST from wherever it is
# installed on the current system
FIND_PACKAGE(Boost 1.39 REQUIRED)
FIND_PACKAGE(Boost REQUIRED COMPONENTS system)
Copy link
Owner

@bangerth bangerth Aug 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a particular reason to remove the minimum version as a requirement?

Copy link
Contributor Author

@dawsoneliasen dawsoneliasen Aug 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still trying to figure it out, windows cmake fails saying it could not find boost. I found a stack overflow post suggesting this might help, but it's still failing...

Copy link
Owner

@bangerth bangerth Aug 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to figure that out on Wed.

Copy link
Owner

@bangerth bangerth Aug 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try undoing this change.

INCLUDE(CheckIncludeFileCXX)

MESSAGE(STATUS "Boost_INCLUDE_DIRS: ${Boost_INCLUDE_DIRS}")
Expand Down