fix web-runner #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logging in stdio breaks it... beginning to rewrite runFile to use some other means of communication. moved message functions into async_testing/lib/messages.js
found a couple of problems with child, tests that logged stuff was breaking reporting, and you could make false positives by outputting a finish message (indicating 0 tests, which is success(!)) started working on another child process implementation, using http. but realised that the messages must be queued, so that they arrive in order.
|
/usr/local/lib/node/.npm/async_testing/9999.0.0-LINK-25de0aad/package/lib/web-runner.js:343 |
|
You should really fix this immediately. It prevents the whole package from even loading. |
kanamouru123
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
found missing } which was preventing web-runner from compiling.