WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Jan 2, 2026

๐ŸŽŸ๏ธ Tracking

PM-30389

๐Ÿ“” Objective

This PR updates the AuthTabs to allow for alternate redirect schemes to be used. Currently only bitwarden is needed but we will be adding more soon.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2026

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ b7f0d30b-3350-4cfd-b07d-1a31c6a5cd3b

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

โœ… All modified and coverable lines are covered by tests.
โœ… Project coverage is 85.50%. Comparing base (674cde9) to head (a950565).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6315      +/-   ##
==========================================
+ Coverage   84.93%   85.50%   +0.56%     
==========================================
  Files         876      763     -113     
  Lines       56942    54623    -2319     
  Branches     7900     7855      -45     
==========================================
- Hits        48366    46706    -1660     
+ Misses       5833     5189     -644     
+ Partials     2743     2728      -15     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

๐Ÿš€ New features to boost your workflow:
  • โ„๏ธ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants