WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Add a runtime API for reset shared heap(chain) #4740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
TianlongLiang wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add a runtime API for reset shared heap(chain) #4740

TianlongLiang wants to merge 2 commits into from
+302 −87

Conversation

@TianlongLiang
Copy link
Collaborator

@TianlongLiang TianlongLiang commented Dec 5, 2025

No description provided.

@yamt
Copy link
Collaborator

yamt commented Dec 8, 2025

can you elaborate use cases a bit?

@TianlongLiang
Copy link
Collaborator Author

TianlongLiang commented Dec 8, 2025

can you elaborate use cases a bit?

For example, if a WASM module calls shared_heap_malloc a few times and an exception occurs before it gets a chance to free it, then the WAMR runtime-managed shared heap will have some dangling pointer(some memory block can't be allocated) until the runtime destroys and reinitializes. This api provides a lighter way to reset(allow the whole WAMR runtime-managed shared heap to become allocatable) the shared heaps without re-initializing the runtime.

@yamt
Copy link
Collaborator

yamt commented Dec 8, 2025

can you elaborate use cases a bit?

For example, if a WASM module calls shared_heap_malloc a few times and an exception occurs before it gets a chance to free it, then the WAMR runtime-managed shared heap will have some dangling pointer(some memory block can't be allocated) until the runtime destroys and reinitializes. This api provides a lighter way to reset(allow the whole WAMR runtime-managed shared heap to become allocatable) the shared heaps without re-initializing the runtime.

so,

  • it's an equivalent of destroy + re-create
  • not intended to be used for a chain being used by running instances

right?

yamt
yamt reviewed Dec 8, 2025
View reviewed changes
tests/unit/shared-heap/shared_heap_test.cc
unsigned int wasm_file_size = 0;
unsigned int stack_size = 16 * 1024, heap_size = app_heap_size;
char error_buf[128] = { 0 };
char error_buf[128] = {};
Copy link
Collaborator

@yamt yamt Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a change for "fix some warnings"?
what warning?

tests/unit/shared-heap/shared_heap_test.cc
EXPECT_EQ(offset, offset_after_reset);
EXPECT_EQ(native_ptr, native_ptr_after_reset);

/* Only on some platform, the os_mmap will memset the memory to 0
Copy link
Collaborator

@yamt yamt Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean that in some cases shared memory may have uninitialized user-visible contents?
is it documented somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yamt yamt yamt left review comments

@loganek loganek Awaiting requested review from loganek loganek is a code owner

@lum1n0us lum1n0us Awaiting requested review from lum1n0us lum1n0us is a code owner

@no1wudi no1wudi Awaiting requested review from no1wudi no1wudi is a code owner

@wenyongh wenyongh Awaiting requested review from wenyongh wenyongh is a code owner

@xujuntwt95329 xujuntwt95329 Awaiting requested review from xujuntwt95329 xujuntwt95329 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TianlongLiang @yamt