WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@isabelroses
Copy link
Member

Perhaps a oversight but a understandable one seeing as we currently only have 1 reactive theme, zed. But that may change with the addition of ghostty!

closes #420

The idea here was to introduce darkFlavor and lightFlavor in a very none breaking way, such that they both default to config.catppuccin.flavor rather then mocha and latte respectively.

@isabelroses isabelroses requested a review from getchoo December 31, 2024 08:33
Comment on lines +29 to +39
darkFlavor = lib.mkOption {
type = catppuccinLib.types.flavor;
default = config.catppuccin.flavor;
description = "Global Catppuccin dark flavor";
};

lightFlavor = lib.mkOption {
type = catppuccinLib.types.flavor;
default = config.catppuccin.flavor;
description = "Global Catppuccin light flavor";
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too big a fan of this API. I think it'd be better to have a single enum option defining whether or not to use dark mode, and continuing using the local flavor option in modules (which should be fine since both can still be overridden on a per-module basis if you'd like light mode with a different-than-global flavor for example)

i.e., this would become

{
  # Or maybe name it `mode`? I dunno
  theme = lib.mkOption {
    type = lib.types.oneOf [ "light" "dark" ];
    default = dark;
    description = "Global Catppuccin theme type";
    example = lib.literalExpression "light";
  };
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the idea, but i assume some people like macOS users would be more wanting to have the dark and light options since they are not enforced into declarative light/dark.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh and totally forgot for ghostty which is a single string, making it a bit hard to do that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too sure how else to generalize this API then. Having dynamic light/dark is virtually exclusive to macOS, and most apps will just not support it; I don't know where else this would really be used besides Ghostty and Zed

If we can configure either of those two to use a "dynamic" mode, I would be fine with that being a third option in this enum -- and those two ports having their own exclusive light/darkFlavor options. Otherwise I don't think this is a good fit here

light =
"Catppuccin "
+ catppuccinLib.mkUpper cfg.flavor
+ catppuccinLib.mkUpper cfg.lightFlavor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would stay the same

Suggested change
+ catppuccinLib.mkUpper cfg.lightFlavor
+ catppuccinLib.mkUpper cfg.flavor

dark =
"Catppuccin "
+ catppuccinLib.mkUpper cfg.flavor
+ catppuccinLib.mkUpper cfg.darkFlavor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And then we would configure zed to use the light or dark theme

...assuming that's possible. I'd really like it to be since I feel like making the light/dark theme choice imperative is a bit odd and unlike what we do with flavors, accents, and enabling the themes themselves

@different-name
Copy link
Contributor

Perhaps a oversight but a understandable one seeing as we currently only have 1 reactive theme, zed. But that may change with the addition of ghostty!

If Firefox Userstyles gets merged, that'd be another - currently setting both light and dark to the same flavor

@hackardoX
Copy link

I'm super excited about this feature! Any idea on how we're going to roll it out?

@HeitorAugustoLN
Copy link
Member

This would be really neat for #549, since COSMIC has support for automatically switching themes when it's day or night

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support separate light/dark themes

5 participants