-
Notifications
You must be signed in to change notification settings - Fork 775
feat(client): add futuresSymbolConfig #958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
carlosmiei
commented
Sep 10, 2025
- relates to There is no futuresSymbolConfig function #955
|
DEMO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds support for fetching futures symbol configuration data from the Binance API by introducing a new futuresSymbolConfig method and corresponding type definition.
- Adds
SymbolConfiginterface to define the structure of symbol configuration data - Implements
futuresSymbolConfigmethod to retrieve symbol configuration from the Binance futures API - Updates imports to include the new
SymbolConfigtype
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/types.ts | Adds SymbolConfig interface with symbol configuration properties |
| src/node-binance-api.ts | Implements futuresSymbolConfig method and imports the new type |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| time: number | ||
| } | ||
|
|
||
|
|
Copilot
AI
Sep 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Remove the extra blank lines before the interface declaration to maintain consistent spacing with the rest of the file.
| } | ||
|
|
||
|
|
||
| export interface SymbolConfig { |
Copilot
AI
Sep 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Remove the extra space before the opening brace to follow consistent formatting.