WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@migmartri
Copy link
Member

@migmartri migmartri commented Dec 12, 2025

Summary

  • Migrated protovalidate from github.com/bufbuild/protovalidate-go to buf.build/go/protovalidate v1.1.0
  • Migrated protoyaml from github.com/bufbuild/protoyaml-go to buf.build/go/protoyaml v0.6.0
  • Created validator adapter in app/controlplane/pkg/unmarshal/unmarshal.go to bridge interface incompatibility
  • Upgraded cosign from v2 to v3 for compatibility with fulcio v1.8.3 and sigstore v1.10.x
  • Updated all import paths across 14 Go files
  • Fixed API changes: GetCertificate()Certificate() in verifier

Current Status

⚠️ Draft - Build is currently blocked by missing cryptoutils.ValidatePubKey in sigstore v1.10.2

  • The function was moved to internal package github.com/sigstore/sigstore/internal/goodkey
  • Waiting for sigstore to re-expose this function publicly (expected in upcoming release)
  • See app/controlplane/pkg/biz/signing.go:176

Related

  • Part of fulcio v1.8.3 upgrade (dependabot branch)

dependabot bot and others added 6 commits December 5, 2025 18:20
Bumps [github.com/sigstore/fulcio](https://github.com/sigstore/fulcio) from 1.6.3 to 1.8.3.
- [Release notes](https://github.com/sigstore/fulcio/releases)
- [Changelog](https://github.com/sigstore/fulcio/blob/main/CHANGELOG.md)
- [Commits](sigstore/fulcio@v1.6.3...v1.8.3)

---
updated-dependencies:
- dependency-name: github.com/sigstore/fulcio
  dependency-version: 1.8.3
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
- Migrated from github.com/bufbuild/protovalidate-go to buf.build/go/protovalidate v1.1.0
- Migrated from github.com/bufbuild/protoyaml-go to buf.build/go/protoyaml v0.6.0
- Created validator adapter to bridge protovalidate v1.1.0 interface changes
- Upgraded cosign from v2 to v3 for compatibility with sigstore v1.10.x
- Updated all import paths and fixed API changes (GetCertificate -> Certificate)

Note: Build currently blocked by missing cryptoutils.ValidatePubKey in sigstore v1.10.2
Signed-off-by: Miguel Martinez <[email protected]>
Signed-off-by: Miguel Martinez <[email protected]>
Signed-off-by: Miguel Martinez <[email protected]>
Signed-off-by: Miguel Martinez <[email protected]>
@migmartri migmartri requested review from javirln and jiparis and removed request for jiparis December 17, 2025 15:59
@migmartri migmartri marked this pull request as ready for review December 17, 2025 15:59
Signed-off-by: Miguel Martinez <[email protected]>
@migmartri migmartri requested review from Piskoo and jiparis December 17, 2025 16:56
@migmartri migmartri merged commit 4a29ebc into chainloop-dev:main Dec 17, 2025
8 of 13 checks passed
@migmartri migmartri deleted the upgrade-protovalidate branch December 17, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants