-
Notifications
You must be signed in to change notification settings - Fork 2k
[BUG] Set default client idle timeout #6001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
|
Set HTTP client pool idle timeout and bump crate versions Introduces a 30-second pool idle timeout on the Key Changes• Imported Affected Areas• This summary was automatically generated by @propel-code-bot |
rescrv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to bump the root Cargo.toml as well.
Might I suggest following this and then we can cut a release: https://github.com/chroma-core/hosted-chroma/blob/main/runbooks/publish-chroma-crates.md
Given a default client timeout of 60s, this sets a much lower value to prevent the client from using "almost timed-out" connections from the pool. Ref: hyperium/hyper#2136 (comment)
Co-authored-by: propel-code-bot[bot] <203372662+propel-code-bot[bot]@users.noreply.github.com>
9c68ac0 to
c01670a
Compare
|
This is fine - I do think a proper keep alive configuration and thought is in order. |
Description of changes
Given a default client timeout of 60s, this sets a much lower value to prevent the client from using "almost timed-out" connections from the pool.
Ref: hyperium/hyper#2136 (comment)
Test plan
ci
Migration plan
n/a
Observability plan
n/a
Documentation Changes
n/a