WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@jkuelz
Copy link
Member

@jkuelz jkuelz commented Dec 3, 2025

Description

Prep for some upcoming changes to theming. Needed in order to make theming-core dryrun pass.

The change that contributes to bundle size increase is the switch from resolved values to css variables.

Before
--color-border-divider-default-kwf8i6: #c6c6cd;
--color-border-dropdown-item-default-8qi3jl: #c6c6cd;
After
--color-border-divider-default-ipvpev: var(--color-neutral-250-hdfqdx);
--color-border-dropdown-item-default-uslwbi: var(--color-border-divider-default-ipvpev);

We are making this change in order to make wholistic theming more efficient by relying on css variables inheritance. Rather than redeclaring all 300+ tokens for the wholistic theming that reference tokens offers, this makes it so that only the themed reference tokens (~30) need to be included in the stylesheet, and the rest can be cascade via native CSS variable inheritance. This change also lets us use less declarations in our own css -- the new exports file is about 250 lines shorter, but css variables use more characters, which increases it overall.

Related links, issue #, if available: n/a

How has this been tested?

Dev-pipeline: AwsUi-v3-jkuelz

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jkuelz jkuelz marked this pull request as ready for review December 3, 2025 10:36
@jkuelz jkuelz requested a review from a team as a code owner December 3, 2025 10:36
@jkuelz jkuelz requested review from ernst-dev and gethinwebster and removed request for a team December 3, 2025 10:36
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.12%. Comparing base (c02fc0d) to head (9f3deee).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4086   +/-   ##
=======================================
  Coverage   97.12%   97.12%           
=======================================
  Files         864      864           
  Lines       25325    25325           
  Branches     9137     9137           
=======================================
  Hits        24597    24597           
  Misses        722      722           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jkuelz jkuelz added this pull request to the merge queue Dec 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 3, 2025
@jkuelz jkuelz added this pull request to the merge queue Dec 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 3, 2025
@jkuelz jkuelz added this pull request to the merge queue Dec 3, 2025
Merged via the queue into main with commit 73773fa Dec 3, 2025
84 of 85 checks passed
@jkuelz jkuelz deleted the jkuelz-theming-bundle-size branch December 3, 2025 11:54
at-susie pushed a commit that referenced this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants