chore: Increase bundle size limit #4086
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prep for some upcoming changes to theming. Needed in order to make theming-core dryrun pass.
The change that contributes to bundle size increase is the switch from resolved values to css variables.
Before
--color-border-divider-default-kwf8i6: #c6c6cd;--color-border-dropdown-item-default-8qi3jl: #c6c6cd;After
--color-border-divider-default-ipvpev: var(--color-neutral-250-hdfqdx);--color-border-dropdown-item-default-uslwbi: var(--color-border-divider-default-ipvpev);We are making this change in order to make wholistic theming more efficient by relying on css variables inheritance. Rather than redeclaring all 300+ tokens for the wholistic theming that reference tokens offers, this makes it so that only the themed reference tokens (~30) need to be included in the stylesheet, and the rest can be cascade via native CSS variable inheritance. This change also lets us use less declarations in our own css -- the new exports file is about 250 lines shorter, but css variables use more characters, which increases it overall.
Related links, issue #, if available: n/a
How has this been tested?
Dev-pipeline: AwsUi-v3-jkuelz
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.