WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@pan-kot
Copy link
Member

@pan-kot pan-kot commented Dec 8, 2025

Description

The flashbar visual context does not have support for a number of common Cloudscape components, including certain variants of text, buttons, key-value pairs, popover.

Before:

Screen.Recording.2025-12-08.at.16.44.57.mov

After:

Screen.Recording.2025-12-09.at.12.09.19.mov

Rel: [AWSUI-61549]

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.12%. Comparing base (5f1e362) to head (a388bf4).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4096   +/-   ##
=======================================
  Coverage   97.12%   97.12%           
=======================================
  Files         864      864           
  Lines       25327    25328    +1     
  Branches     9141     9141           
=======================================
+ Hits        24599    24600    +1     
- Misses        681      722   +41     
+ Partials       47        6   -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pan-kot pan-kot force-pushed the fix-flashbar-context-kvp-popover branch from 0949f36 to a388bf4 Compare December 10, 2025 09:46
@pan-kot pan-kot marked this pull request as ready for review December 10, 2025 10:28
@pan-kot pan-kot requested a review from a team as a code owner December 10, 2025 10:28
@pan-kot pan-kot requested review from ernst-dev and removed request for a team December 10, 2025 10:28
@pan-kot pan-kot changed the title fix: WIP: Flashbar context for key-value pairs and popover fix: Flashbar context for key-value pairs and popover Dec 12, 2025
@pan-kot pan-kot added this pull request to the merge queue Dec 12, 2025
Merged via the queue into main with commit da6682c Dec 12, 2025
50 checks passed
@pan-kot pan-kot deleted the fix-flashbar-context-kvp-popover branch December 12, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants