WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@pan-kot
Copy link
Member

@pan-kot pan-kot commented Dec 11, 2025

Description

This fixes the issue when a table with variant full-page, embedded or borderless would be horizontally scrollable when it should not.

Rel: [AWSUI-61443]

Before:

Screen.Recording.2025-12-11.at.15.40.24.mov

After:

The table is no longer horizontally scrollable when in full-page, embedded or borderless variant.

How has this been tested?

TBA

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.12%. Comparing base (81f493f) to head (73d3c5e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4102      +/-   ##
==========================================
- Coverage   97.12%   97.12%   -0.01%     
==========================================
  Files         864      864              
  Lines       25327    25326       -1     
  Branches     9141     9140       -1     
==========================================
- Hits        24599    24598       -1     
  Misses        681      681              
  Partials       47       47              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

}
}

th:last-child > .resizer:not(.is-visual-refresh) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was some old rule that never applied (because the descendant of the th is .resize-wrapper, not .resizer.

@pan-kot pan-kot force-pushed the fix-table-resizer-overflow branch from 7ea5fd8 to 73d3c5e Compare December 11, 2025 15:55
@pan-kot pan-kot marked this pull request as ready for review December 11, 2025 16:46
@pan-kot pan-kot requested a review from a team as a code owner December 11, 2025 16:46
@pan-kot pan-kot requested review from Who-is-PS and removed request for a team December 11, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant