WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@chris-adam
Copy link
Contributor

@chris-adam chris-adam commented Sep 18, 2025

No description provided.

remove_gs_step('collective.iconifiedcategory:default-postInstall')


def upgrade_to_2107(context):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ceci n'a pas du tout été testé. Je me suis fortement inspiré de l'upgrade "upgrade_to_2101"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pour ia.Docs, est-ce que ceci va se déclencher pour les fichiers déjà créés ? Si oui, faut qu'on parle ;-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A priori, oui

@chris-adam chris-adam marked this pull request as ready for review September 18, 2025 14:06
status = 1
values = {'approved': True}
else:
status = 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On rencontre ce cas quand ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je pense qu'on pouvait passer un état en query parameter mais après vérification, non. Le paramètre "values" est overidé directement. Le comportement par défaut était de lire les query parameters.

Le status code 2 indique une erreur.

remove_gs_step('collective.iconifiedcategory:default-postInstall')


def upgrade_to_2107(context):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pour ia.Docs, est-ce que ceci va se déclencher pour les fichiers déjà créés ? Si oui, faut qu'on parle ;-)

@chris-adam chris-adam force-pushed the approved_column branch 3 times, most recently from 64207ee to e8b767c Compare September 19, 2025 08:59
@sgeulette
Copy link
Member

Il faudrait en fait ajouter un "champ" to_approve pour au final avoir le même mécanisme que "to_sign" et "signed"...

@chris-adam chris-adam force-pushed the approved_column branch 4 times, most recently from 1408210 to 997af90 Compare October 8, 2025 12:29
@sgeulette sgeulette merged commit 5ded2d2 into master Oct 9, 2025
6 checks passed
@sgeulette sgeulette deleted the approved_column branch October 9, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants