-
Notifications
You must be signed in to change notification settings - Fork 1
Added "Approved?" column to the categorized elements table #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| remove_gs_step('collective.iconifiedcategory:default-postInstall') | ||
|
|
||
|
|
||
| def upgrade_to_2107(context): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ceci n'a pas du tout été testé. Je me suis fortement inspiré de l'upgrade "upgrade_to_2101"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pour ia.Docs, est-ce que ceci va se déclencher pour les fichiers déjà créés ? Si oui, faut qu'on parle ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A priori, oui
| status = 1 | ||
| values = {'approved': True} | ||
| else: | ||
| status = 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On rencontre ce cas quand ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je pense qu'on pouvait passer un état en query parameter mais après vérification, non. Le paramètre "values" est overidé directement. Le comportement par défaut était de lire les query parameters.
collective.iconifiedcategory/src/collective/iconifiedcategory/browser/actionview.py
Line 208 in 64207ee
| def set_values(self, values): |
Le status code 2 indique une erreur.
src/collective/iconifiedcategory/locales/fr/LC_MESSAGES/collective.iconifiedcategory.po
Outdated
Show resolved
Hide resolved
src/collective/iconifiedcategory/locales/fr/LC_MESSAGES/collective.iconifiedcategory.po
Show resolved
Hide resolved
| remove_gs_step('collective.iconifiedcategory:default-postInstall') | ||
|
|
||
|
|
||
| def upgrade_to_2107(context): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pour ia.Docs, est-ce que ceci va se déclencher pour les fichiers déjà créés ? Si oui, faut qu'on parle ;-)
64207ee to
e8b767c
Compare
e8b767c to
26d8ea2
Compare
|
Il faudrait en fait ajouter un "champ" to_approve pour au final avoir le même mécanisme que "to_sign" et "signed"... |
ad27cc4 to
f4b498a
Compare
f4b498a to
b1a2d98
Compare
1408210 to
997af90
Compare
a7f4684 to
608d03f
Compare
No description provided.