WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@bigcat88
Copy link
Contributor

Found by chance by a type checker, looks like a typo in the code.

Right now NodeOutput.from_dict will always raise an exception, as NodeOutput class does not define args argument as possible kwarg.

Tested on such code in the V3 node:

return {"result": [output_text, "something else"]}

This will lead to such exception during execution:

File "/home/shurik/Comfy/ComfyUI-work/comfy_api/latest/_io.py", line 1541, in EXECUTE_NORMALIZED_ASYNC
    to_return = NodeOutput.from_dict(to_return)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/shurik/Comfy/ComfyUI-work/comfy_api/latest/_io.py", line 1818, in from_dict
    return cls(args=args, ui=ui, expand=expand)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: NodeOutput.__init__() got an unexpected keyword argument 'args'

@bigcat88
Copy link
Contributor Author

+label: Core

@comfy-pr-bot comfy-pr-bot added the Core Core team dependency label Dec 10, 2025
@Kosinkadink Kosinkadink merged commit 36357bb into comfyanonymous:master Dec 10, 2025
12 checks passed
@bigcat88 bigcat88 deleted the fix/node-output-dict branch December 11, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core Core team dependency

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants