WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@jjerphan
Copy link
Member

@jjerphan jjerphan commented Mar 12, 2025

fmt 11.1 broke the ABI, breaking some builds of packages, including the one of spdlog and mamba 2.0.7.

In the meantime new builds of mamba have been issued to fix the problem.

See: mamba-org/mamba#3862

@jjerphan jjerphan requested a review from a team as a code owner March 12, 2025 11:13
@SylvainCorlay
Copy link
Member

This looks good to me.

@jjerphan
Copy link
Member Author

Gentle ping, @hmaarrfk.

@hmaarrfk
Copy link
Contributor

what does this mean for 24 build we just released?

@SylvainCorlay
Copy link
Member

SylvainCorlay commented Mar 12, 2025

Here is the issue:

  • Version 11.1 of fmt broke it's ABI.
  • Spdlog is built with 11.0, and having it installed with 11.1 breaks it.
  • Mamba depends on both spdlog and fmt directly.

Note: The release of Spdlog 11.1 was published on conda-forge between the last RC and the Final of Mamba, so this was not picked up in the RC.

References:

conda-forge/fmt-feedstock#61
conda-forge/spdlog-feedstock#68

There is a discussion on marking fmt 11.1 as broken.

@hmaarrfk
Copy link
Contributor

I don't really have time to really read through these issues today.

My question is more:

Do we need to pull:
https://github.com/conda-forge/miniforge/releases/tag/24.11.3-1

If so, i would like a new build of conda 24.11.3 since I"ve been personally reverting mamba2 on some of my systems due consistency issues.

@SylvainCorlay
Copy link
Member

SylvainCorlay commented Mar 12, 2025

Do we need to pull: https://github.com/conda-forge/miniforge/releases/tag/24.11.3-1

I think so, unless we are fine shipping miniforge with packages marked as broken.

(I think we should have marked fmt 11.1.* as broken until an ABI-compatible patch release is available upstream).

@hmaarrfk
Copy link
Contributor

well could this PR then please revert mamba2 as well?

@SylvainCorlay
Copy link
Member

SylvainCorlay commented Mar 12, 2025

well could this PR then please revert mamba2 as well?

Why? (note that all projects depending on fmt where impacted by this ABI breakage)

@hmaarrfk
Copy link
Contributor

as i mentionned, i've personally had trouble with the mamba1 -> mamba2 transition on a few of my machines quite literally yesterday. It has just been a very tiring transition that has made me consider dropping mamba from Miniforge3 alltogether (I don't want to do it, but I think it is something to consider given the amount of recent churn it has caused me personally). #730 (comment)

I understand that this is a fresh install, but if the build from 24.11.3-1 is problematic, then I want to make sure we release 1 build in March 2025 (with all the fixes that @jjerphan pushed to constructor) for mamba1.

Please don't get me wrong, I'm extremely happy you and @jjerphan are helping more recently with Miniforge, and it is a main reason why I'm backing off from my proposal of dropping mamba from Miniforge.

However, I think it would be great to have 2 release:

  1. One with mamba1
  2. One with mamba2

in quick succession to help revert in case we need to.

@jjerphan
Copy link
Member Author

jjerphan commented Mar 12, 2025

#737 recreated installers for 1.5.12 with the latest version of constructor (for the 24.11.3-1 version of those installers).

This PR recreates installers for the second builds of 2.0.7 (which are sane because built for fmt<11.1) with the latest version of constructor.

So both versions of the installers can released and used IMO.

@SylvainCorlay
Copy link
Member

as i mentionned, i've personally had trouble with the mamba1 -> mamba2 transition on a few of my machines quite literally yesterday. It has just been a very tiring transition that has made me consider dropping mamba from Miniforge3 alltogether (I don't want to do it, but I think it is something to consider given the amount of recent churn it has caused me personally). #730 (comment)

The transition from Mamba 1 to Mamba 2 has indeed been tiring, even for the maintenance team. However, the Mamba 2 codebase is significantly simpler and readable, more thoroughly tested, and more robust than its predecessor. It should be much simpler to maintain in the long run.

The ABI breakage of fmt that occured between our last RC and the final release for this patch version is sheer bad luck - but the team is on the deck working on it, and improving the constructor.

Besides, there will be second order benefits to using Mamba 2 over Mamba 1, such as support for OCI registries, mirrors, etc.

@hmaarrfk
Copy link
Contributor

if we are rebuilding for

  • mamba2 + fmt 11.1 workaround

i would rather first build for

  • mamba1 + fmt 11.1 workaround
  • mamba2 + fmt 11.1 workaround

in quick succession.

Is it ok if i merge #741 then bring back the mamba2 changes?

@SylvainCorlay
Copy link
Member

i would rather first build for

  • mamba1 + fmt 11.1 workaround
  • mamba2 + fmt 11.1 workaround

in quick succession.

Is it ok if i merge #741 then bring back the mamba2 changes?

I don't have an objection.

@SylvainCorlay SylvainCorlay mentioned this pull request Mar 12, 2025
5 tasks
@hmaarrfk hmaarrfk closed this Mar 13, 2025
@hmaarrfk
Copy link
Contributor

Just built a pre-release tag with 11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants