-
-
Notifications
You must be signed in to change notification settings - Fork 454
Rebuild miniforge installation scripts #738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Julien Jerphanion <[email protected]>
|
This looks good to me. |
|
Gentle ping, @hmaarrfk. |
|
what does this mean for 24 build we just released? |
|
Here is the issue:
Note: The release of Spdlog 11.1 was published on conda-forge between the last RC and the Final of Mamba, so this was not picked up in the RC. References: conda-forge/fmt-feedstock#61 There is a discussion on marking fmt 11.1 as broken. |
|
I don't really have time to really read through these issues today. My question is more: Do we need to pull: If so, i would like a new build of conda 24.11.3 since I"ve been personally reverting mamba2 on some of my systems due consistency issues. |
I think so, unless we are fine shipping miniforge with packages marked as broken. (I think we should have marked fmt 11.1.* as broken until an ABI-compatible patch release is available upstream). |
|
well could this PR then please revert mamba2 as well? |
Why? (note that all projects depending on fmt where impacted by this ABI breakage) |
|
as i mentionned, i've personally had trouble with the mamba1 -> mamba2 transition on a few of my machines quite literally yesterday. It has just been a very tiring transition that has made me consider dropping I understand that this is a fresh install, but if the build from Please don't get me wrong, I'm extremely happy you and @jjerphan are helping more recently with Miniforge, and it is a main reason why I'm backing off from my proposal of dropping However, I think it would be great to have 2 release:
in quick succession to help revert in case we need to. |
|
#737 recreated installers for 1.5.12 with the latest version of constructor (for the This PR recreates installers for the second builds of 2.0.7 (which are sane because built for fmt<11.1) with the latest version of constructor. So both versions of the installers can released and used IMO. |
The transition from Mamba 1 to Mamba 2 has indeed been tiring, even for the maintenance team. However, the Mamba 2 codebase is significantly simpler and readable, more thoroughly tested, and more robust than its predecessor. It should be much simpler to maintain in the long run. The ABI breakage of Besides, there will be second order benefits to using Mamba 2 over Mamba 1, such as support for OCI registries, mirrors, etc. |
|
if we are rebuilding for
i would rather first build for
in quick succession. Is it ok if i merge #741 then bring back the mamba2 changes? |
I don't have an objection. |
|
Just built a pre-release tag with 11.0 |
fmt 11.1broke the ABI, breaking some builds of packages, including the one of spdlog and mamba 2.0.7.In the meantime new builds of mamba have been issued to fix the problem.
See: mamba-org/mamba#3862