WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@Zweihorn
Copy link
Contributor

Skip special "sidebar" & "[c|i]_template" pages in Quality Report if conf was selected.

  • establish conf and code accordingly
  • some clarification in comments in 'renderer.php'
  • some typo fix(es)

CAVEAT: Please extra check plugin.info.txt as an old commit was included by me unfortunately.

Skip special "sidebar" & "[c|i]_template" pages in Quality Report if conf was selected.
- establish conf and code accordingly
- some clarification in comments in 'renderer.php'
- some typo fix(es)
@Zweihorn
Copy link
Contributor Author

ref #57 - pos. (1.)

@Zweihorn
Copy link
Contributor Author

IMHO the qc page analysis for each page should remain intentionally

  • allows a quality check of the respective page as may be applicable e.g., for templates
  • avoids too much tinkering with existing code and "keep it running, keep it simple"

Hope this helps.

🌻

@splitbrain
Copy link
Member

I think it would make more sense to add a skip option that accepts a regular expression, so users can configure arbitrary pages or namespaces to be skipped instead of hard coding certain page names as special. Many other plugins implement similar settings.

@Zweihorn
Copy link
Contributor Author

I think it would make more sense to add a skip option that accepts a regular expression, so users can configure arbitrary pages or namespaces to be skipped instead of hard coding certain page names as special. Many other plugins implement similar settings.

Good point but IMHO misleading rationale and overkill solution.

Please note (or better recall, as you yourself seem to be the dev here, I presume) the exisitng feature of Disabling Checks on a Page by putting a ~~NOQC~~ macro somewhere into the page. This is an out of the box solution and in my eyes quite sufficient.

Hope this helps.

@splitbrain - Please consider and resolve at your earliest convenience.

NB
Please accept my apologies for the delay as I have my life outside GitHub mainly.
🌻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants